bug(clojure) Now highlights defn- properly (#2438)

highlightjs · Mar 3, 2020 · ffe4a94 · ffe4a94
1 parent 98edcfc
commit ffe4a94
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -17,6 +17,7 @@ Core Changes:
 
 Language Improvements:
 
+- bug(clojure) Now highlights `defn-` properly (#2438) [Josh Goebel][]
 - enh(clojure) Add support for global definitions name (#2347) [Alexandre Grison][]
 - enh(fortran) Support Fortran 77 style comments (#2416) [Josh Goebel][]
 - (csharp) add support for `@identifier` style identifiers (#2414) [Josh Goebel][]

diff --git a/src/languages/clojure.js b/src/languages/clojure.js
@@ -94,6 +94,7 @@ export default function(hljs) {
 
   var GLOBAL = {
     beginKeywords: globals,
+    lexemes: SYMBOL_RE,
     end: '(\\[|\\#|\\d|"|:|\\{|\\)|\\(|$)',
     contains: [
       {

diff --git a/src/lib/mode_compiler.js b/src/lib/mode_compiler.js
@@ -83,7 +83,12 @@ export function compileLanguage(language) {
 
     if (parent) {
       if (mode.beginKeywords) {
-        mode.begin = '\\b(' + mode.beginKeywords.split(' ').join('|') + ')\\b';
+        // for languages with keywords that include non-word characters checking for
+        // a word boundary is not sufficient, so instead we check for a word boundary
+        // or whitespace - this does no harm in any case since our keyword engine
+        // doesn't allow spaces in keywords anyways and we still check for the boundary
+        // first
+        mode.begin = '\\b(' + mode.beginKeywords.split(' ').join('|') + ')(?=\\b|\\s)';
       }
       if (!mode.begin)
         mode.begin = /\B|\b/;

diff --git a/test/markup/clojure/globals_definition.expect.txt b/test/markup/clojure/globals_definition.expect.txt
@@ -22,7 +22,7 @@
 (<span class="hljs-keyword">defonce</span> ^<span class="hljs-symbol">:private</span> <span class="hljs-title">another-var</span> #<span class="hljs-string">"foo"</span>)
 
 <span class="hljs-comment">; private function</span>
-(<span class="hljs-keyword">defn</span><span class="hljs-title">-</span> add [x y] (<span class="hljs-name"><span class="hljs-builtin-name">+</span></span> x y))
+(<span class="hljs-keyword">defn-</span> <span class="hljs-title">add</span> [x y] (<span class="hljs-name"><span class="hljs-builtin-name">+</span></span> x y))
 
 <span class="hljs-comment">; protocols</span>
 (<span class="hljs-keyword">defprotocol</span> <span class="hljs-title">Fly</span>