fix(python) def, class keywords detected mid-identifier (#3381)

highlightjs · Nov 16, 2021 · 10b322d · 10b322d
1 parent ef45496
commit 10b322d
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 3 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -2,6 +2,7 @@
 
 Grammars:
 
+- fix(python) def, class keywords detected mid-identifier (#3381) [Josh Goebel][]
 - fix(python) Fix recognition of numeric literals followed by keywords without whitespace (#2985) [Richard Gibson][]
 - enh(swift) add SE-0290 unavailability condition (#3382) [Bradley Mackey][]
 - enh(java) add `sealed` and `non-sealed` keywords (#3386) [Bradley Mackey][]
@@ -22,6 +23,7 @@ Developer Tools:
 [Richard Gibson]: https://github.com/gibson042
 [Bradley Mackey]: https://github.com/bradleymackey
 [Björn Ebbinghaus]: https://github.com/MrEbbinghaus
+[Josh Goebel]: https://github.com/joshgoebel
 
 ## Version 11.3.1
 

diff --git a/src/languages/python.js b/src/languages/python.js
@@ -384,7 +384,7 @@ export default function(hljs) {
       hljs.HASH_COMMENT_MODE,
       {
         match: [
-          /def/, /\s+/,
+          /\bdef/, /\s+/,
           IDENT_RE,
         ],
         scope: {
@@ -397,14 +397,14 @@ export default function(hljs) {
         variants: [
           {
             match: [
-              /class/, /\s+/,
+              /\bclass/, /\s+/,
               IDENT_RE, /\s*/,
               /\(\s*/, IDENT_RE,/\s*\)/
             ],
           },
           {
             match: [
-              /class/, /\s+/,
+              /\bclass/, /\s+/,
               IDENT_RE
             ],
           }

diff --git a/test/markup/python/false_positives.expect.txt b/test/markup/python/false_positives.expect.txt
@@ -0,0 +1,5 @@
+foo = _undef
+bar
+
+booger = _unclass
+burger
diff --git a/test/markup/python/false_positives.txt b/test/markup/python/false_positives.txt
@@ -0,0 +1,5 @@
+foo = _undef
+bar
+
+booger = _unclass
+burger