Filter by log level #4445
Merged
Filter by log level #4445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Easy and customizable dashboards for your build system. Learn more about Stoat ↗︎ Job Runtime |
et
requested review from
a team,
ccschmitz,
Vadman97,
aptlin and
mayberryzane
and removed request for
a team
|
Your Render PR Server URL is https://frontend-pr-4445.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cg0clpo2qv25rrvq34sg. |
et
commented
Mar 2, 2023
et
force-pushed
the
4443-filter-by-log-level
branch
from
aca0f5e
to
bd3813f
Compare
et
force-pushed
the
4443-filter-by-log-level
branch
from
bd3813f
to
1aba3a9
Compare
This was referenced Mar 6, 2023
et
added a commit
that referenced
this pull request
Mar 7, 2023
## Summary <!-- Ideally, there is an attached Linear ticket that will describe the "why". If relevant, use this section to call out any additional information you'd like to _highlight_ to the reviewer. --> For #4471, we intend to add copy buttons for each log property (to prefill the query). To prepare for that, we should rename OTEL lingo to a more product friendly lingo, specifically: * SeverityText -> level (to coincide with #4445) * Body -> message (since every other logging app calls it this) Additionally, these should sit as top level keys like `trace_id`, `span_id`, and `secure_session_id` (#4468) ## How did you test this change? <!-- Frontend - Leave a screencast or a screenshot to visually describe the changes. --> Verified that `level` and `message` are top level keys in the JSON view:  ## Are there any deployment considerations? <!-- Backend - Do we need to consider migrations or backfilling data? --> A follow up PR will come that will add support for searching `message:value` (#4510)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support to filter by the log level (internally called
SeverityText).Will follow up for adding support for trace id and other non-custom attributes.
This PR also replaces squirrel with go-sqlbuilder. There's a couple reasons for this:
UNIONsupport. We'll need this for permalinking (example). Per the previous point, it doesn't seem like squirrel will add union support even with a PR ready.How did you test this change?
Unit tests added for testing level filtering. Our existing tests should cover the squirrel -> go-sqlbuilder transition
Click test:
Are there any deployment considerations?
N/A