Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dash/edit-mode-custom-layout #21179

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

vazonik
Copy link
Member

@vazonik vazonik commented May 16, 2024

Added the ability to use the edit mode for custom layouts.


TO DO:

  • CSS refactoring
  • Crate tools init
  • Default modules
  • Sidebar position
  • Toolbars
  • Context detection
  • Documentation about CSS and limitations
  • Check documentation and move scattered parts into one article

@vazonik vazonik added Changelog: Feature Use on PR to add description as a feature in the generated changelog. Product: Highcharts Dashboards labels May 16, 2024
@vazonik vazonik self-assigned this May 16, 2024
@highsoft-bot
Copy link
Collaborator

highsoft-bot commented May 16, 2024

File size comparison

Sizes for compiled+gzipped (bold) and compiled files.

master candidate difference
dashboards/dashboards.js 43.2 kB
148.6 kB
43.2 kB
148.6 kB
-3 B
7 B
dashboards/modules/layout.js 11.7 kB
45.9 kB
11.8 kB
45.9 kB
33 B
34 B

@highsoft-bot
Copy link
Collaborator

highsoft-bot commented May 16, 2024

Lighthouse report

dashboards-demo-minimal.json

Reference Proposed Diff
performance – score 1 1 0.00
first-contentful-paint – score 1 1 0.00
first-contentful-paint – milliseconds 198.75 187.63 -11.12
first-meaningful-paint – score 1 1 0.00
first-meaningful-paint – milliseconds 442.16 438.9 -3.26
dom-size – score 1 1 0.00
dom-size – elements 344 344 0.00

@highsoft-bot
Copy link
Collaborator

highsoft-bot commented May 16, 2024

Dashboard visual diffs

No differences found

@highsoft-bot
Copy link
Collaborator

Visual test results - No difference found

@highsoft-bot
Copy link
Collaborator

highsoft-bot commented May 16, 2024

Benchmark report - Dashboards

benchmarks/Dashboards/DataPool-CSV-constructor.bench.ts

Sample size This PR avg (ms) master avg (ms) Diff Percent diff
2500000 0.16 0.16 0 1%
See all
Sample size This PR avg (ms) master avg (ms) Diff Percent diff
100 0.16 0.16 0 -2%
1000 0.16 0.16 0 -1%
10000 0.16 0.16 0 -1%
100000 0.16 0.16 0 -1%
1000000 0.16 0.16 0 -2%
2500000 0.16 0.16 0 1%

benchmarks/Dashboards/DataTable-loading-columns.bench.ts

Sample size This PR avg (ms) master avg (ms) Diff Percent diff
2500000 16.54 16.88 -0.34 -2%
See all
Sample size This PR avg (ms) master avg (ms) Diff Percent diff
100 0.23 0.24 0 -1%
1000 0.24 0.24 0 2%
10000 0.27 0.27 0 1%
100000 2.7 2.38 0.32 13%
1000000 8.88 9.21 -0.33 -4%
2500000 16.54 16.88 -0.34 -2%

benchmarks/Dashboards/DataTable-loading-rows.bench.ts

Sample size This PR avg (ms) master avg (ms) Diff Percent diff
2500000 739.22 740.01 -0.79 0%
See all
Sample size This PR avg (ms) master avg (ms) Diff Percent diff
100 0.28 0.28 0 0%
1000 0.52 0.52 0 -1%
10000 3.19 2.69 0.49 18%
100000 15.44 15.91 -0.46 -3%
1000000 284.06 285.63 -1.56 -1%
2500000 739.22 740.01 -0.79 0%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Feature Use on PR to add description as a feature in the generated changelog. Product: Highcharts Dashboards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants