Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/21144-chromium-bug #21170

Merged
merged 1 commit into from
May 29, 2024
Merged

bugfix/21144-chromium-bug #21170

merged 1 commit into from
May 29, 2024

Conversation

hubertkozik
Copy link
Member

@hubertkozik hubertkozik commented May 15, 2024 •
edited

Temporary fixed #21144, chromium bug while touching and scrolling chart.

It seems to me, that isChrome flag wasn't working in the latest versions of Google Chrome, that's why I changed it also.

@hubertkozik hubertkozik added Product: Highcharts Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog. labels May 15, 2024
@hubertkozik hubertkozik self-assigned this May 15, 2024
@highsoft-bot
Copy link
Collaborator

File size comparison

Sizes for compiled+gzipped (bold) and compiled files.

master candidate difference
highcharts.js 95.8 kB
270.2 kB		 95.8 kB
270.2 kB		 21 B
17 B
highstock.js 128.6 kB
371.9 kB		 128.7 kB
371.9 kB		 22 B
17 B
highmaps.js 121.7 kB
349.7 kB		 121.7 kB
349.7 kB		 23 B
17 B
highcharts-gantt.js 133.8 kB
385.8 kB		 133.8 kB
385.9 kB		 23 B
17 B
dashboards/dashboards.js 43.1 kB
148.4 kB		 43.1 kB
148.3 kB		 -2 B
-22 B
datagrid/datagrid.js 24.7 kB
76.8 kB		 24.7 kB
76.8 kB		 -1 B
-44 B

@highsoft-bot
Copy link
Collaborator

Visual test results - No difference found

goransle
goransle approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@goransle goransle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

MarkusBarstad
MarkusBarstad approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@MarkusBarstad MarkusBarstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@hubertkozik hubertkozik marked this pull request as ready for review May 28, 2024 13:35
TorsteinHonsi
TorsteinHonsi approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TorsteinHonsi TorsteinHonsi merged commit b1fcbf7 into master May 29, 2024
13 checks passed
@TorsteinHonsi TorsteinHonsi deleted the bugfix/21144-chromium-bug branch May 29, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorsteinHonsi TorsteinHonsi TorsteinHonsi approved these changes

@goransle goransle goransle approved these changes

@MarkusBarstad MarkusBarstad MarkusBarstad approved these changes

Assignees

@hubertkozik hubertkozik

Labels
Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog. Product: Highcharts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The chart and browser freeze when active scrolling
5 participants
@hubertkozik @highsoft-bot @TorsteinHonsi @goransle @MarkusBarstad