Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dash/error-msg #21160

Merged
merged 2 commits into from
May 22, 2024
Merged

dash/error-msg #21160

merged 2 commits into from
May 22, 2024

Conversation

karolkolodziej
Copy link
Contributor

@karolkolodziej karolkolodziej commented May 14, 2024

Improved error messages when options were misconfigured, see #21091.


@karolkolodziej karolkolodziej added Changelog: Feature Use on PR to add description as a feature in the generated changelog. Product: Highcharts Dashboards labels May 14, 2024
@karolkolodziej karolkolodziej self-assigned this May 14, 2024
@highsoft-bot
Copy link
Collaborator

highsoft-bot commented May 14, 2024

File size comparison

Sizes for compiled+gzipped (bold) and compiled files.

master candidate difference
dashboards/dashboards.js 43.1 kB
148.4 kB
43.1 kB
148.5 kB
34 B
152 B
dashboards/modules/layout.js 11.7 kB
45.8 kB
11.7 kB
45.8 kB
16 B
19 B

@highsoft-bot
Copy link
Collaborator

highsoft-bot commented May 14, 2024

Lighthouse report

dashboards-demo-minimal.json

Reference Proposed Diff
performance – score 1 1 0.00
first-contentful-paint – score 1 1 0.00
first-contentful-paint – milliseconds 219.75 188.14 -31.61
first-meaningful-paint – score 1 1 0.00
first-meaningful-paint – milliseconds 441.13 445.5 4.37
dom-size – score 1 1 0.00
dom-size – elements 346 346 0.00

@highsoft-bot
Copy link
Collaborator

highsoft-bot commented May 14, 2024

Dashboard visual diffs

Visual differences found in:

  • /home/runner/work/highcharts/highcharts/cypress/snapshots/actual/test/cypress/dashboards/visual/dashboards-demo-minimal-loaded.png

See artifacts in the run summary for screenshots

@highsoft-bot
Copy link
Collaborator

Visual test results - No difference found

@highsoft-bot
Copy link
Collaborator

highsoft-bot commented May 14, 2024

Benchmark report - Dashboards

benchmarks/Dashboards/DataTable-loading-rows.bench.ts

Sample size This PR avg (ms) master avg (ms) Diff Percent diff
2500000 747.79 743.1 4.69 1%
See all
Sample size This PR avg (ms) master avg (ms) Diff Percent diff
100 0.29 0.29 0 2%
1000 0.52 0.53 -0.01 -2%
10000 3.19 2.78 0.41 15%
100000 16.55 16.2 0.35 2%
1000000 287.29 291.03 -3.74 -1%
2500000 747.79 743.1 4.69 1%

benchmarks/Dashboards/DataPool-CSV-constructor.bench.ts

Sample size This PR avg (ms) master avg (ms) Diff Percent diff
2500000 0.17 0.17 0 1%
See all
Sample size This PR avg (ms) master avg (ms) Diff Percent diff
100 0.17 0.16 0.01 3%
1000 0.17 0.16 0 2%
10000 0.16 0.17 -0.01 -3%
100000 0.17 0.17 0 1%
1000000 0.16 0.16 0 1%
2500000 0.17 0.17 0 1%

benchmarks/Dashboards/DataTable-loading-columns.bench.ts

Sample size This PR avg (ms) master avg (ms) Diff Percent diff
2500000 16.12 16.23 -0.11 -1%
See all
Sample size This PR avg (ms) master avg (ms) Diff Percent diff
100 0.24 0.24 0 2%
1000 0.24 0.24 0 1%
10000 0.28 0.28 0 0%
100000 2.41 2.3 0.1 5%
1000000 9.33 8.87 0.46 5%
2500000 16.12 16.23 -0.11 -1%

@karolkolodziej karolkolodziej changed the title Improved error measages when options misconfigured. dash/error-msg May 14, 2024
@karolkolodziej karolkolodziej marked this pull request as ready for review May 14, 2024 09:27
@sebastianbochan sebastianbochan merged commit 36f3196 into master May 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Feature Use on PR to add description as a feature in the generated changelog. Product: Highcharts Dashboards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants