demo/pnf-series-move-to-demo

[kamil-musialowski]

Added new demo category called Experimental, moved and improved Point and figure series.

[highsoft-bot]

File size comparison

No differences found

[highsoft-bot]

Visual test results - No difference found

---

Samples changed

Change type	Sample
Modified	samples/stock/demo/pointandfigure/demo.js
Modified	samples/stock/demo/pointandfigure/demo.js
Modified	samples/stock/demo/pointandfigure/demo.js
Modified	samples/stock/demo/pointandfigure/demo.js
Modified	samples/stock/demo/pointandfigure/demo.js
Modified	samples/stock/demo/pointandfigure/demo.js
?	samples/highcharts/studies/pointandfigure/demo.js

[pawelfus]

In addition to the comment below:

• can we adjust the space between columns of points? I mean - decrease the space?

[pawelfus]

As discussed:

• let's go back to columnMetric solutions
• set max width for the shape, to avoid too flat shapes

[pawelfus]

One last thing, promise! :D

When you zoom in close enough, it throws errors in the console - could you simply fix it using if clause? By close enough I mean no visible points

Note:
There are also some problems with panning, but for now, let's ignore them

[pawelfus]

Thanks!

[TorsteinHonsi]

Thanks, it looks good! I have some comments on the structure of the code itself:

• What we are demonstrating is a plugin. So I think the demo should have a clearer separation between the plugin and the actual demo (the chart config and generation). The plugin itself doesn't have to be inside the async IIFE. But it can be in an IIFE so that it is clearly encapsulated. This is a good pattern:

(({ isNumber, relativeLength, defined, pick }) => {
    // Plugin code here
})(Highcharts);

• We should have some more comments. Most importantly, a comment for the plugin itself, stating that this is a complicated demo showing an experimental feature of Highcharts Stock, but also serving as a demonstration for how to extend the library. The point is that we don't want readers to see this code and believe that it is complicated to set up Highcharts Stock. The plugin may look intimidating, so we need to explain what it is.
• Now the async IIFE should contain only the chart configuration itself.

[pawelfus]

Is there anything else to add here @TorsteinHonsi ? Or is it ready to merge?

[TorsteinHonsi]

Looks good, thanks 👍