Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recursor: send DS queries to the parent zone #2203

Merged
merged 1 commit into from May 18, 2024

Conversation

japaric
Copy link
Contributor

@japaric japaric commented Apr 29, 2024

the DS records have to be signed by the parent so they are stored in the parent zone. therefore, the resolver needs to send the query to the parent zone.

this fixes the conformance tests added in ferrous-systems/dnssec-tests#54

with this change, delv works with hickory-dns:

$ delv -p 1053 @127.0.0.1 +rtrace www.example.com.
;; fetch: www.example.com/A
;; fetch: example.com/DNSKEY
;; fetch: example.com/DS
;; fetch: com/DNSKEY
;; fetch: com/DS
;; fetch: ./DNSKEY
; fully validated

this PR builds on top of #2196 so I'm going to leave in draft state until that one is merged

@japaric japaric marked this pull request as ready for review May 13, 2024 08:43
@japaric
Copy link
Contributor Author

japaric commented May 13, 2024

rebased and ready for review now that PR #2196 has been merged

@bluejekyll
Copy link
Member

Looks great, thanks for the PR!

@bluejekyll bluejekyll merged commit f868f8e into hickory-dns:main May 18, 2024
18 checks passed
@japaric japaric deleted the ja-ds-query branch May 22, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants