Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): update ip of example.com #2187

Merged
merged 2 commits into from Apr 20, 2024

Conversation

situ2001
Copy link
Contributor

@situ2001 situ2001 commented Apr 19, 2024

When running test of my app, I found that the test failed due to the IP of example.com being changed and also discovered that hickory dns has the same issue. So I proceeded to take the following steps to fix the test.

  1. Change IPv4: from 93.184.216.34 to 93.184.215.14
  2. Change IPv6: from 2606:2800:220:1:248:1893:25c8:1946 to 2606:2800:21f:cb07:6820:80da:af6b:8b2c

I searched for all occurrences and replaced them until cargo test is passed. And I'm unsure whether I need to do anything more for the tests that run locally. For example,

assert_eq!(record.data().unwrap(), &RData::A(A::new(93, 184, 216, 34)));

Reference: Here is another repo that fixed this issues 1d ago Chia-Network/chia-blockchain#17894

I hope you can review it patiently, as there are many files involved in the changes. Thank you. Additionally, do we need to add a global variable or environment variable to handle future IP changes?

@bluejekyll
Copy link
Member

Thank you!

Copy link
Member

@bluejekyll bluejekyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bluejekyll bluejekyll merged commit cad6eed into hickory-dns:main Apr 20, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants