Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.24.1 #2178

Merged
merged 14 commits into from Apr 16, 2024
Merged

Prepare 0.24.1 #2178

merged 14 commits into from Apr 16, 2024

Conversation

bluejekyll
Copy link
Member

@djc and @dlon, this contains the patch for your fix.

should we include anything else? any Cargo.lock updates?

@djc
Copy link
Collaborator

djc commented Apr 14, 2024

You mean this is a backport for #2171, right? @faern was asking about that, not the PR's OP.

IMO it would be good to add enough other commits to get the CI pipeline passing (probably semver-compatible dependency updates and clippy fixes?).

@bluejekyll bluejekyll changed the title Fix socket shutdown Prepare 0.24.1 Apr 14, 2024
@bluejekyll
Copy link
Member Author

Yes, I back ported 2171, I think that was the commit that I grabbed.

Let me see about these other changes.

@bluejekyll
Copy link
Member Author

Ok, I think this is all correct. ended up cherry-picking everything, but didn't do a great job on the order. Let me know if you think that's a problem, and I can reorder.

@bluejekyll
Copy link
Member Author

@dlon if you have a moment, could you confirm this has all the changes you require?

@djc
Copy link
Collaborator

djc commented Apr 15, 2024

As mentioned before: while dlon started the original PR, @faern was the person asking for a release containing it.

@dlon
Copy link
Contributor

dlon commented Apr 16, 2024

@djc @bluejekyll Yep, looks good to me. Thank you!

@djc djc merged commit 29b2905 into release/0.24 Apr 16, 2024
17 checks passed
@djc djc deleted the fix-socket-shutdown branch April 16, 2024 07:39
@djc djc mentioned this pull request Apr 16, 2024
@faern
Copy link
Contributor

faern commented Apr 16, 2024

Thank you! Looking forward to the release ✨

@djc
Copy link
Collaborator

djc commented Apr 16, 2024

@faern @dlon hit a bit of a snag, see #2184 for follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants