Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make hickory_proto::quic::QuicClientStream Clonable #2176

Merged
merged 1 commit into from Apr 10, 2024
Merged

Make hickory_proto::quic::QuicClientStream Clonable #2176

merged 1 commit into from Apr 10, 2024

Conversation

0xffffharry
Copy link
Contributor

quinn::Connection is clonable. This can reuse hickory_proto::quic::QuicClientStream.

djc
djc approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The audit issue is fixed in #2177.

@0xffffharry
Copy link
Contributor Author

the quinn::Connection is clonable. Maybe can fix the h3 module to reuse hickory_proto::h3::H3ClientStream.

@djc djc merged commit 6c2a1e2 into hickory-dns:main Apr 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@bluejekyll bluejekyll bluejekyll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0xffffharry @djc @bluejekyll