fix(proto): fix internal representation of OPT #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation of OPT represents options as hash map, which prevents same `EdnsCode` from appearing more than once. There are options that may appear more than once (e.g. EDE https://www.rfc-editor.org/rfc/rfc8914.html). Unfortunately, this is a breaking change. I haven't figured out a solution that would not break the API and would not introduce some kind of overhead. BREAKING CHANGE: Changes representation of OPT from `HashMap` to a `Vec`, which means that `as_ref` and `as_mut` also now return `&Vec` rather than `&HashMap`.
djc
approved these changes
Feb 22, 2024
That makes sense. I have added the comment as well as a utility for reading all options for a specific code. |
djc
approved these changes
Feb 27, 2024
bluejekyll
reviewed
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of OPT represents options as hash map, which prevents same
EdnsCodefrom appearing more than once. There are options that may appear more than once(e.g. EDE https://www.rfc-editor.org/rfc/rfc8914.html).
Unfortunately, this is a breaking change. I haven't figured out a solution that would not break the API and would not introduce some kind of overhead.
BREAKING CHANGE: Changes representation of OPT from
HashMapto aVec, which means thatas_refandas_mutalso now return&Vecrather than&HashMap.