cargo: Enable LTO on release build

[jpds]

No description provided.

[bluejekyll]

I think I fixed the cleanliness issues. In terms of LTO, I used to see some issues with it functioning properly. Can you do us a favor, and list out the reasons for wanting it enabled? It would also be great to show before and after binary sizes to show the value here.

[jpds]

In terms of LTO, I used to see some issues with it functioning properly.

Do you remember any details on this? I've had LTO enabled on a number of Rust-based projects on my systems for some time now and haven't noticed any issues with them. Including the VMM I use for my VM infra.

Can you do us a favor, and list out the reasons for wanting it enabled?

Basically just to have the linker produce optimized binaries.

It would also be great to show before and after binary sizes to show the value here.

Before:

.rwxr-xr-x@ 6.3M user 11 Mar 22:04 dns
.rwxr-xr-x@  10M user 11 Mar 22:04 hickory-dns
.rwxr-xr-x@ 7.2M user 11 Mar 22:04 recurse
.rwxr-xr-x@ 6.9M user 11 Mar 22:04 resolve

After:

.rwxr-xr-x@ 2.8M user 11 Mar 22:09 dns
.rwxr-xr-x@ 4.6M user 11 Mar 22:09 hickory-dns
.rwxr-xr-x@ 2.9M user 11 Mar 22:09 recurse
.rwxr-xr-x@ 3.0M user 11 Mar 22:09 resolve

[bluejekyll]

Thank you, I appreciate the follow up. Will merge, and thanks for the PR!

[bluejekyll]

Do we want s or 3 here? I'm a little uncomfortable with optimizing for size, when I think we in most cases want to optimize for speed, i.e. 3. It seems like if people want to override the project default they can pretty easily?

[bluejekyll]

I'd prefer this to be symbols to be clearer which strip mode is being enabled.