Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DON'T MERGE] Remove Default from ResolverOpts #2035

Closed
wants to merge 1 commit into from
Closed

[DON'T MERGE] Remove Default from ResolverOpts #2035

wants to merge 1 commit into from

Conversation

daxpedda
Copy link
Contributor

As discussed in #2031.

@daxpedda daxpedda marked this pull request as draft September 22, 2023 15:50
@daxpedda daxpedda changed the title Remove Default from ResolverOpts [DON'T MERGE] Remove Default from ResolverOpts Sep 22, 2023
@daxpedda
Copy link
Contributor Author

Actually just realized this introduces another problem ...

@daxpedda daxpedda mentioned this pull request Sep 22, 2023
Open
@bluejekyll
Copy link
Member

I think I missed the discussion on this. Are you considering adding a parameter to new() as well? b/c otherwise there shouldn't be any difference, right?

@daxpedda
Copy link
Contributor Author

I think I missed the discussion on this. Are you considering adding a parameter to new() as well? b/c otherwise there shouldn't be any difference, right?

The point was to add a -> Result<Self>.
I will close this though until we figure out #2038. Right now I'm still strongly in favor of not doing this in ResolverOpts at all.

@daxpedda daxpedda closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daxpedda @bluejekyll