Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazily reap finished connections in TokioHandle on spawn_bg #1917

Merged
merged 1 commit into from Mar 31, 2023
Merged

Lazily reap finished connections in TokioHandle on spawn_bg #1917

merged 1 commit into from Mar 31, 2023

Conversation

jeff-hiner
Copy link
Contributor

Fixes #1910

@hottea773
Copy link

I've just done a test of my repro scenario and this does fix it! Thanks @jeff-hiner

@jeff-hiner
Copy link
Contributor Author

Fantastic! Thanks for the debugging and the repro, and my apologies for missing this in the other reap fix.

@bluejekyll
Copy link
Member

Thank you for tracking this down! I was wondering if the previous changes in this area might have been related. It does make me wonder, could we put a #[must_use] on a type here?

@jeff-hiner
Copy link
Contributor Author

I'm not sure #[must_use] would have caught this, tbh. We are "using" the inner value to add to it, we just weren't ever reaping the finished tasks.

@bluejekyll
Copy link
Member

Thanks again for fixing this. Merging.

@bluejekyll bluejekyll merged commit 9f196c5 into hickory-dns:main Mar 31, 2023
17 checks passed
@jeff-hiner jeff-hiner deleted the reap_resolver branch May 15, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@bluejekyll bluejekyll bluejekyll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak when responses timeout
4 participants
@jeff-hiner @hottea773 @bluejekyll @djc