Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rustls, tokio-rustls, quinn #1916

Merged
merged 1 commit into from May 15, 2023
Merged

Conversation

cpu
Copy link
Contributor

@cpu cpu commented Mar 29, 2023

Description

This branch updates the Rustls dependency to the recently released 0.21.0 tag. I expect this release will be of particular interest to Trust DNS users because it brings support for IP address subjects in certificates and I understand that to be a common requirement for DoT/DoH.

It also introduces updates to tokio-rustls and quinn to releases using the same 0.21.0 rustls dependency.

Within the Trust DNS codebase a couple small upstream API changes are addressed to ensure the build and tests pass.

Remaining work

@mokeyish
Copy link
Contributor

LGTM, In order to experience this, I have supported here. 😂

https://github.com/mokeyish/smartdns-rs/blob/a96cdbf43c96f792473af133d3e4804aa540e9d6/Cargo.toml#L41-L45

@zh-jq
Copy link
Contributor

zh-jq commented Mar 31, 2023

Maybe we should wait for rustls/webpki-roots#28 and replace webpki with rustls-webpki

@cpu
Copy link
Contributor Author

cpu commented Mar 31, 2023

Maybe we should wait for rustls/webpki-roots#28 and replace webpki with rustls-webpki

Sounds reasonable. I added this to the remaining work list.

Cargo.toml Outdated Show resolved Hide resolved
@bluejekyll
Copy link
Member

How's this going? seems like it would be good to wait for this for the next release?

@cpu
Copy link
Contributor Author

cpu commented Apr 13, 2023

How's this going? seems like it would be good to wait for this for the next release?

We're just waiting on quinn-rs/quinn#1528 and a Quinn release. What kind of time frame were you looking at for cutting a trust-dns release? O(days) or something further out? :-)

@djc djc mentioned this pull request Apr 26, 2023
4 tasks
@cpu cpu force-pushed the cpu-rustls-0.21.0 branch 2 times, most recently from 7b5ece0 to 1cb0dd6 Compare May 11, 2023 12:41
@cpu cpu marked this pull request as ready for review May 11, 2023 13:22
@cpu
Copy link
Contributor Author

cpu commented May 11, 2023

@bluejekyll @djc Thanks to the Quinn 0.10 release getting cut this branch is rebased and ready for review :-)

@djc djc changed the title WIP: deps: update rustls, tokio-rustls, quinn. Update rustls, tokio-rustls, quinn May 11, 2023
@djc
Copy link
Collaborator

djc commented May 11, 2023

Awesome, thanks!

@bluejekyll
Copy link
Member

Oh. Awesome. I can review, the 0.23 alpha failed to publish yesterday so I can include this in that publish.

Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpu would you mind rebasing this again?

This commit updates the Rustls dependency to the recently released
0.21.0 tag, and to update tokio-rustls to 0.24.0 to use the same rustls
release. It also updates webpki-roots to 0.23.0, and to use rustls' fork
of webpki instead of the original.

A couple of small upstream API changes are addressed to ensure the build
and tests pass.
@djc djc merged commit 2b78a1f into hickory-dns:main May 15, 2023
17 checks passed
@cpu cpu deleted the cpu-rustls-0.21.0 branch May 15, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants