-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rustls, tokio-rustls, quinn #1916
Conversation
LGTM, In order to experience this, I have supported here. 😂 |
Maybe we should wait for rustls/webpki-roots#28 and replace webpki with rustls-webpki |
Sounds reasonable. I added this to the remaining work list. |
How's this going? seems like it would be good to wait for this for the next release? |
We're just waiting on quinn-rs/quinn#1528 and a Quinn release. What kind of time frame were you looking at for cutting a trust-dns release? O(days) or something further out? :-) |
7b5ece0
to
1cb0dd6
Compare
@bluejekyll @djc Thanks to the Quinn 0.10 release getting cut this branch is rebased and ready for review :-) |
Awesome, thanks! |
Oh. Awesome. I can review, the 0.23 alpha failed to publish yesterday so I can include this in that publish. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpu would you mind rebasing this again?
This commit updates the Rustls dependency to the recently released 0.21.0 tag, and to update tokio-rustls to 0.24.0 to use the same rustls release. It also updates webpki-roots to 0.23.0, and to use rustls' fork of webpki instead of the original. A couple of small upstream API changes are addressed to ensure the build and tests pass.
Description
This branch updates the Rustls dependency to the recently released 0.21.0 tag. I expect this release will be of particular interest to Trust DNS users because it brings support for IP address subjects in certificates and I understand that to be a common requirement for DoT/DoH.
It also introduces updates to tokio-rustls and quinn to releases using the same 0.21.0 rustls dependency.
Within the Trust DNS codebase a couple small upstream API changes are addressed to ensure the build and tests pass.
Remaining work