reduce size of ResolveErrorKind #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1482 +/- ##
==========================================
- Coverage 84.45% 84.43% -0.03%
==========================================
Files 167 167
Lines 15805 15811 +6
==========================================
+ Hits 13348 13349 +1
- Misses 2457 2462 +5 |
I'm not sure what caused this to fail. Changes in clippy?
1.52 is out
|
I can't reproduce CI error, and it has no apparent error message, could you try re-running it in case it's a fluke? Otherwise I have no idea what is wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1383 part2
Reduce size of
ResolveErrorby boxing some parts of its inner enum#1409 already boxed
ProtoErrorKindinProtoError