add non_exhaustive to public enums #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluejekyll
force-pushed
the
non_exhaustive_patterns
branch
from
0033877
to
8da5f8d
Compare
Codecov Report
@@ Coverage Diff @@
## main #1426 +/- ##
==========================================
- Coverage 83.71% 83.69% -0.02%
==========================================
Files 167 167
Lines 15865 15867 +2
==========================================
- Hits 13280 13279 -1
- Misses 2585 2588 +3 |
|
In my opinion, semver compatibility trumps the ability to exhaustively match enums. The contract that semver-compatible versions should just compile is widely upheld, and we should not mess with it. The clippy lint seems like a fine solution for those who really want to make sure they match every variant. |
|
ok, let me clean this up and get it ready. |
bluejekyll
force-pushed
the
non_exhaustive_patterns
branch
2 times, most recently
from
44b8833
to
d2fc75b
Compare
|
Ok @djc I think this is ready, unless you see something missing. |
bluejekyll
force-pushed
the
non_exhaustive_patterns
branch
from
d2fc75b
to
4ff167c
Compare
bluejekyll
force-pushed
the
non_exhaustive_patterns
branch
from
4ff167c
to
2642183
Compare
|
@djc any concerns with me merging this? |
|
I can review it tomorrow. |
djc
approved these changes
Apr 6, 2021
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if we want to make this guarantee. But It's worth putting it up for discussion.
We know that record types will be coming in the future, but adding non_exhaustive to RecordType is also a bit annoying because the RecordTypes are mostly fixed. So The question here is, where do we want to add non_exhaustive such that minor and patch releases are forward compatible. Do we want to make forward compatibility a guarantee on perhaps on patch releases, but not minor releases? See #1425, which happened on a pre 1.0 patch release as an example.
How extreme do we want to be on this at the detriment of losing one of Rusts greatest checks (all enum variants are covered in a match statement).
Fixes: #1425