Make all warnings across crates and binaries consistent #1401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@leshow, Here's that PR. This makes all warnings across the crates consistent. I adopted most of your recommendations, except for the
Debug
one. That would have been really messy because there are a lot of external types that are not themselves Debug.We can merge this after your PR, since it has the overlap on
Copy
in theproto
cratedepends on: #1397