Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all warnings across crates and binaries consistent #1401

Merged
merged 1 commit into from Mar 8, 2021

Conversation

bluejekyll
Copy link
Member

@bluejekyll bluejekyll commented Mar 5, 2021

@leshow, Here's that PR. This makes all warnings across the crates consistent. I adopted most of your recommendations, except for the Debug one. That would have been really messy because there are a lot of external types that are not themselves Debug.

We can merge this after your PR, since it has the overlap on Copy in the proto crate

depends on: #1397

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #1401 (603a3ad) into main (a44d441) will increase coverage by 0.03%.
The diff coverage is 78.02%.

@@            Coverage Diff             @@
##             main    #1401      +/-   ##
==========================================
+ Coverage   85.16%   85.19%   +0.03%     
==========================================
  Files         153      152       -1     
  Lines       15038    14958      -80     
==========================================
- Hits        12806    12743      -63     
+ Misses       2232     2215      -17     

@bluejekyll bluejekyll force-pushed the consistent-warnings-across-crates branch 3 times, most recently from cfe543b to 87d395a Compare March 6, 2021 01:04
@leshow
Copy link
Contributor

leshow commented Mar 7, 2021

Looks good to me!

@bluejekyll bluejekyll force-pushed the consistent-warnings-across-crates branch from 87d395a to 603a3ad Compare March 8, 2021 22:03
@bluejekyll bluejekyll merged commit 6fcc72a into main Mar 8, 2021
@bluejekyll bluejekyll deleted the consistent-warnings-across-crates branch March 8, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants