New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[async-std-resolver] Re-export AsyncStdConnection(Provider) #1354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable!
Codecov Report
@@ Coverage Diff @@
## main #1354 +/- ##
=======================================
Coverage 86.29% 86.29%
=======================================
Files 132 132
Lines 13775 13775
=======================================
Hits 11886 11886
Misses 1889 1889 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for the PR! |
@djc and @bluejekyll would it be possible to release a new version of |
Yes, it's definitely possible. Let me see about a couple of PRs that might land soon before we do the next release. |
Thanks @bluejekyll for the new release! |
Analogous to the definition of
TokioAsyncResolver
with re-exportedTokioConnection
andTokioConnectionProvider
, it would be useful to haveAsyncStdConnection
andAsyncStdConnectionProvider
re-exported in the public API ofasync-std-resolver
, so that types like thiscan be instantiated via