Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trust-dns-proto 0.20.1 contains BC breakage #1425

Closed
icewind1991 opened this issue Mar 28, 2021 · 1 comment · Fixed by #1426
Closed

trust-dns-proto 0.20.1 contains BC breakage #1425

icewind1991 opened this issue Mar 28, 2021 · 1 comment · Fixed by #1426
Labels
crate:proto

Comments

@icewind1991
Copy link

#1402 adds additional fields to the public RData enum, which breaks any code that performs an exhaustive match on it.
@bluejekyll
Copy link
Member

I've been considering making that non-exhaustive, seems like this is a good reason to do that.

@bluejekyll bluejekyll mentioned this issue Mar 28, 2021
Merged
@djc djc closed this as completed in #1426 Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crate:proto
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add non_exhaustive to public enums hickory-dns/hickory-dns
2 participants
@bluejekyll @icewind1991