HHH-14370 + HHH-14371 + HHH-14372 - Add required --add-opens options for Gradle, Weld, Javassist #3677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
changed the title
|
I added a few commits to also fix tests. |
In order to work around illegal accesses in Gradle. Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Turns out getJvmArgs() returns a copy, so modifying that copy won't change the JVM args. Signed-off-by: Yoann Rodière <yoann@hibernate.org>
NamingHelper test needs access to Charset.defaultCharset. Signed-off-by: Yoann Rodière <yoann@hibernate.org>
… unnamed module in tests Weld needs this, in CDI tests. Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Otherwise they won't be executed with the appropriate JVM args. Signed-off-by: Yoann Rodière <yoann@hibernate.org>
… tests Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
…ests Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Sanne
approved these changes
Dec 14, 2020
Yes, but only after we backport the toolchain support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-14370
https://hibernate.atlassian.net/browse/HHH-14371
https://hibernate.atlassian.net/browse/HHH-14372
Workaround for gradle/gradle#15538 , and a few more
--add-opensto make tests work when illegal access is disabled. Strangely, we weren't using--illegal-access=deny? Anyway, JDK16-ea28 makes that the default.This should fix compilation and tests on JDK16-ea28.
See https://ci.hibernate.org/view/Personal%20jobs/job/hibernate-orm-personal-yoann-jdk16/20/
Please do not backport to 5.4 yet: we need to backport the upgrade to toochains first.