Fixup: repair sallys-blog to match updated website design #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added support for sallys-blog.de * Added missing test for sallys-blog.de total time * Fixed formatting and string handling of sallys-blog.de scraper * Removed unused dependency from sallys-blog.de scraper (cherry picked from commit 516e7f4)
…ngraph image property is found on the page
hhursev
reviewed
Mar 14, 2023
| @@ -47,6 +47,6 @@ def decorated_method_wrapper(self, *args, **kwargs): | |||
| image = self.soup.find( | |||
| "meta", {"property": "og:image", "content": True} | |||
| ) | |||
| return image.get("content") | |||
| return image.get("content") if image else None | |||
hhursev
reviewed
Mar 14, 2023
| return normalize_string(self.soup.head.find("title").get_text()) | ||
|
|
||
| def image(self): | ||
| raise NotImplementedError() # todo: probably better to return URLs than base64 content |
There was a problem hiding this comment.
fwiw I'm ok with something (kinda-ugly) like:
from urllib.parse import unquote
.....
def image(self):
image_element = self.soup.find("div", {"class": "images-wrap"}).findAll("img", {"sizes": "100vw"})[0]
image_src = image_element["src"]
image_url = unquote(image_src).split("url=")[1].split("&")[0]
return image_url
There was a problem hiding this comment.
Nice! I hadn't noticed those image links. That sounds like a good approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #739.