Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup / workaround: provide tox 'install_command' for the 'py' unit test environment name #701

Closed
wants to merge 3 commits into from

Conversation

jayaddison
Copy link
Collaborator

Attempts to resolve #698 (I've tested this locally, but not on an OSX platform, so I'm uncertain whether tests will pass across all platforms).

Bases upon #700 so that both install command configurations are consistent (and both are consistent with the tox default).

@jayaddison
Copy link
Collaborator Author

Ok - the py-darwin install_command evaluated to python -I -m pip install -r /Users/runner/work/recipe-scrapers/recipe-scrapers/requirements-dev.txt python -I -m pip install --only-binary=lxml '{opts}' '{packages}' (with the pip install string appearing twice instead of once).

That seems odd.

@jayaddison
Copy link
Collaborator Author

There could be ways to adjust the tox.ini file to make this work with tox v4.0.8 and above. An alternative could be to pin to earlier versions of tox. I'm undecided yet about how to proceed -- either way, there could be another bug report to file here related to the duplication-of-install-command-contents.

…' unit test environment name"

This reverts commit 6e357f4.
@jayaddison
Copy link
Collaborator Author

To unblock continuous integration testing, pinning tox to <4 may be a shorter-term solution.

@jayaddison jayaddison marked this pull request as draft December 13, 2022 17:26
@jayaddison
Copy link
Collaborator Author

Superseded by #704.

@jayaddison jayaddison closed this Dec 16, 2022
@jayaddison jayaddison deleted the issue-698/tox-env-name-update branch December 16, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continuous integration build failure: tox dependency installation
1 participant