Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: schema.org parser #671

Merged
merged 10 commits into from Oct 24, 2022
Merged

Refactor: schema.org parser #671

merged 10 commits into from Oct 24, 2022

Commits on Oct 24, 2022

  1. Add an item-level in-context check to SchemaOrg graph item handling

    @jayaddison
    jayaddison committed Oct 24, 2022
    Copy the full SHA
    2df327d View commit details
    Browse the repository at this point in the history

  2. Refactor: only test the 'in_context' variable once during SchemaOrg i… 

    …tem handling
    @jayaddison
    jayaddison committed Oct 24, 2022
    Copy the full SHA
    44aaa30 View commit details
    Browse the repository at this point in the history

  3. Simplification: reduce a conditional-test-and-then-loop into a loop

    @jayaddison
    jayaddison committed Oct 24, 2022
    Copy the full SHA
    662bb5e View commit details
    Browse the repository at this point in the history

  4. Refactor: simplify schema.org itemtype checking

    @jayaddison
    jayaddison committed Oct 24, 2022
    Copy the full SHA
    0f8c84d View commit details
    Browse the repository at this point in the history

  5. Nitpick: consolidate a two-line conditional check

    @jayaddison
    jayaddison committed Oct 24, 2022
    Copy the full SHA
    82e2da6 View commit details
    Browse the repository at this point in the history

  6. Move item-schematype check method into staticmethod

    @jayaddison
    jayaddison committed Oct 24, 2022
    Copy the full SHA
    5683088 View commit details
    Browse the repository at this point in the history

  7. Use a variable to hold mainEntity

    @jayaddison
    jayaddison committed Oct 24, 2022
    Copy the full SHA
    216698c View commit details
    Browse the repository at this point in the history

  8. Linting fixup

    @jayaddison
    jayaddison committed Oct 24, 2022
    Copy the full SHA
    6114997 View commit details
    Browse the repository at this point in the history

  9. Cleanup: remove SCHEMA_NAMES constant

    @jayaddison
    jayaddison committed Oct 24, 2022
    Copy the full SHA
    ac62a98 View commit details
    Browse the repository at this point in the history

  10. Add explanatory comments

    @jayaddison
    jayaddison committed Oct 24, 2022
    Copy the full SHA
    e452a61 View commit details
    Browse the repository at this point in the history