Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the scraper-generator template. Inherit from abc.ABC in AbstractScraper #664

Merged
merged 7 commits into from Dec 16, 2022
Merged

Update the scraper-generator template. Inherit from abc.ABC in AbstractScraper #664

merged 7 commits into from Dec 16, 2022

Commits on Oct 28, 2022

  1. Modify base 'AbstractScraper' class to inherit from Python 'abc.ABC' … 

    …abstract base class
    @jayaddison
    jayaddison committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    686d36d View commit details
    Browse the repository at this point in the history

  2. Reorganize template scraper method order, placing abstract methods ne… 

    …arest the top of the class definition
    @jayaddison
    jayaddison committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    c8ca5f6 View commit details
    Browse the repository at this point in the history

  3. Raise an exception when field information is not provided by a host

    @jayaddison
    jayaddison committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    3ea825e View commit details
    Browse the repository at this point in the history

  4. Lint fixups: unused import, linebreak for exceptions

    @jayaddison
    jayaddison committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    47cdf0d View commit details
    Browse the repository at this point in the history

  5. Fixup: invoke instead of reference host method from within f-strings

    @jayaddison
    jayaddison committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    28ff143 View commit details
    Browse the repository at this point in the history

  6. Omit some newlines added during editing/experimentaion, reducing the … 

    …overall diff to v15 branch
    @jayaddison
    jayaddison committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    64f87df View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Merge branch 'v15' into issue-617/reduce-template-methods

    @jayaddison
    jayaddison committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    ce44b50 View commit details
    Browse the repository at this point in the history