Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continuous integration: re-enable coveralls test coverage upload #637

Merged
merged 3 commits into from Oct 16, 2022
Merged

Continuous integration: re-enable coveralls test coverage upload #637

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c1e37c
Restore Coveralls GitHub Action for Python
jayaddison Oct 13, 2022
da0a704
Only attempt to run coveralls uploads on Linux platforms
jayaddison Oct 13, 2022
9b4a314
Add the coveralls repo token back in github actions
hhursev Oct 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/unittests.yaml
View file
Open in desktop
Expand Up @@ -43,3 +43,10 @@ jobs:
- name: Unittest and Coverage Report
run: |
python run_tests.py
# Provide code coverage reports on Linux
- if: ${{ matrix.os == 'ubuntu-latest' }}
name: coveralls.io
uses: AndreMiras/coveralls-python-action@develop
with:
# coveralls repo token
github-token: "SmlfzlVJy4ow55rduU7IU5GmmFCfAdGeq"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be able to use a GitHub encrypted secret to pass this along, and then this could become something like github-token: ${{ secrets.coveralls_repository_token }}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

which is stopping me from implementing. I'd like to see the coveralls report when builds are triggered by PRs from forked repos

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh, nothing is ever easy with computers :( That's an annoying limitation, makes sense to use the fixed token (I hope it's only valid for use with this repository on the Coveralls side).