New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup for OS selection in GitHub Actions unittests workflow #628
Changes from 5 commits
d818fb6
2163c58
a353612
4d839d1
9956ae4
93c0c86
401a0ca
bdf58c5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,11 +10,16 @@ on: | |
|
||
jobs: | ||
test: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
os: [ubuntu-latest, macos-latest, windows-latest] | ||
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11.0-rc.1"] | ||
jayaddison marked this conversation as resolved.
Show resolved
Hide resolved
|
||
exclude: | ||
- os: macos-latest | ||
python-version: "3.11.0-rc.1" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Strangely, all of the For that version, schema data extraction failed for the generic There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm having trouble figuring this one out. Despite enabling debug logging, there wasn't much additional context in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Roughly speaking: it's as if the unit test doesn't read the HTML content correctly (or at all?) when the The errors arise when the scraper-under-test attempts to retrieve parsed schema.org JSON-LD fields from the content. For example, we see:
Note that this is happening in Py3.10 as well as seen in the latest builds. |
||
- os: windows-latest | ||
python-version: "3.11.0-rc.1" | ||
runs-on: ${{ matrix.os }} | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Set up Python | ||
|
@@ -28,8 +33,3 @@ jobs: | |
- name: Unittest and Coverage Report | ||
run: | | ||
python run_tests.py | ||
- name: coveralls.io | ||
uses: AndreMiras/coveralls-python-action@develop | ||
with: | ||
# coveralls repo token | ||
github-token: "SmlfzlVJy4ow55rduU7IU5GmmFCfAdGeq" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's been pretty lame on my part 😅