Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use isodate library to attempt ISO 8601 duration parsing in get_minutes #610

Merged
merged 5 commits into from Oct 12, 2022
Merged

Use isodate library to attempt ISO 8601 duration parsing in get_minutes #610

merged 5 commits into from Oct 12, 2022

Commits on Sep 30, 2022

  1. Add test coverage for get_minutes parsing of ISO8601 time durations

    @jayaddison
    jayaddison committed Sep 30, 2022
    Copy the full SHA
    1bc9e14 View commit details
    Browse the repository at this point in the history

  2. Add explicit isodate library dependency 

    Note: we already currently depend on this library implicitly; it is required by rdflib which is required by extruct
    @jayaddison
    jayaddison committed Sep 30, 2022
    Copy the full SHA
    c8ce9f2 View commit details
    Browse the repository at this point in the history

  3. Use isodate library to attempt to parse time durations from strings t… 

    …hat look like potential ISO8601 date strings in get_minutes utility method
    @jayaddison
    jayaddison committed Sep 30, 2022
    Copy the full SHA
    5becb52 View commit details
    Browse the repository at this point in the history

  4. Ignore flake8 complexity check failure for get_minutes method 

    Refactoring and simplification would be useful here
    @jayaddison
    jayaddison committed Sep 30, 2022
    Copy the full SHA
    95d9cdf View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2022

  1. Nitpick: remove expected value from subtest descriptive arguments

    @jayaddison
    jayaddison committed Oct 1, 2022
    Copy the full SHA
    7c2adf9 View commit details
    Browse the repository at this point in the history