Idea/suggestion: refactor: describe unavailable/static fields using exceptions. #1132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow us to describe in code:
FieldNotProvidedByWebsiteException
)StaticValueException
)In both cases, a placeholder
return_value
can be specified -- and by default that's what the calling code will receive.If some developer/user wants to adjust that -- maybe they don't want to allow any static/unknown values appearing in their application -- they can disable the
StaticValueExceptionHandlingPlugin
plugin.Credits
This suggestion includes ideas from discussion with @mlduff and @rmdluo, particulary from pull requests #1067 and #1098.
Notes
Currently this does also emit warnings in our
unittest
output. See #1112 for an idea about how that could be adjusted in future.