Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox.ini: tox4 compatibility #704

Merged
merged 6 commits into from
Dec 16, 2022
Merged

tox.ini: tox4 compatibility #704

merged 6 commits into from
Dec 16, 2022

Conversation

jayaddison
Copy link
Collaborator

@jayaddison jayaddison commented Dec 15, 2022

Ideally, the goal here is to update tox.ini so that it's backwards-compatible with tox v3, while also allowing us to upgrade to tox v4 in the nearish future.

Relates to #698.

…name, and rename 'py-darwin' environment to 'workaround-darwin' so that it does not match both 'install_command' configuration entries
…n v4, pending resolution of environment-name / platform matching issues"

This reverts commit 573803609f1d15102782cd6aad6a54a013e81935.
@jayaddison jayaddison marked this pull request as ready for review December 15, 2022 15:34
@jayaddison
Copy link
Collaborator Author

jayaddison commented Dec 15, 2022

Note: there are notes from tox upstream to indicate that pip flags should be considered deprecated, and all pip configuration settings should use the supported PIP_-prefixed environment variables as alternatives.

I'm sorta on the fence about whether that's a good idea - environment variables aren't displayed in process tree lists (ps output, for example), and the use of --only-binary=lxml is potentially kinda important here, and not good to hide unnecessarily.

In addition, there's no specific test coverage in pip for the PIP_ONLY_BINARY environment variable. It's probably covered implicitly, and the documentation suggests that it should work - but test coverage is generally a stronger guarantee.

However: duplicating the pip install_command isn't exactly long-term maintenance-free either. Especially if it becomes unavailable from tox v5 onwards, as the maintainers there indicate.

@jayaddison jayaddison marked this pull request as draft December 15, 2022 16:27
@jayaddison
Copy link
Collaborator Author

I think f5e3f1d is probably worth reverting, since this is intended to (continue to) support tox v3 environments for a while.

@jayaddison jayaddison marked this pull request as ready for review December 16, 2022 21:23
@jayaddison jayaddison merged commit e6df256 into main Dec 16, 2022
@jayaddison jayaddison deleted the issue-698/tox4-compatibility branch December 16, 2022 21:23
jayaddison added a commit that referenced this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant