Fixup for OS selection in GitHub Actions unittests workflow #628
Conversation
…in the job's matrix variables
…nation from unittest matrix
I believe that our coveralls integration no longer uses GitHub Actions, so I think that this should be safe to do
…tion from unittest matrix
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest, windows-latest] | ||
| python-version: ["3.7", "3.8", "3.9", "3.10", "3.11.0-rc.1"] | ||
| exclude: | ||
| - os: macos-latest | ||
| python-version: "3.11.0-rc.1" |
There was a problem hiding this comment.
Strangely, all of the macos-latest builds succeeded except for one running this release candidate version of Py3.11.
For that version, schema data extraction failed for the generic wild_mode scraper test.
There was a problem hiding this comment.
I'm having trouble figuring this one out. Despite enabling debug logging, there wasn't much additional context in the wild_mode scraper test failure output.
There was a problem hiding this comment.
Roughly speaking: it's as if the unit test doesn't read the HTML content correctly (or at all?) when the TestWildMode test runs.
The errors arise when the scraper-under-test attempts to retrieve parsed schema.org JSON-LD fields from the content. For example, we see:
File "/Users/runner/work/recipe-scrapers/recipe-scrapers/recipe_scrapers/_factory.py", line 21, in cook_time
return self.schema.cook_time()
^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/runner/work/recipe-scrapers/recipe-scrapers/recipe_scrapers/_schemaorg.py", line 120, in cook_time
raise SchemaOrgException("Cooktime information not found in SchemaOrg")
recipe_scrapers._exceptions.SchemaOrgException: recipe-scrapers exception: Cooktime information not found in SchemaOrg
Note that this is happening in Py3.10 as well as seen in the latest builds.
…cos-latest, 3.11.0-rc.1} during GHA build of 9956ae4
…t failure noted at #628 (comment) bug could have been introduced Attempted reading and comparing the 3.10.x and 3.11.x changelogs since the failure affects both lineages of Python, but that hasn't produced any definitive answers yet
…om unittest matrix
…t failure noted at #628 (comment) bug could have been introduced Attempted reading and comparing the 3.10.x and 3.11.x changelogs since the failure affects both lineages of Python, but that hasn't produced any definitive answers yet
…t failure noted at #628 (comment) bug could have been introduced Attempted reading and comparing the 3.10.x and 3.11.x changelogs since the failure affects both lineages of Python, but that hasn't produced any definitive answers yet
…t failure noted at #628 (comment) bug could have been introduced Attempted reading and comparing the 3.10.x and 3.11.x changelogs since the failure affects both lineages of Python, but that hasn't produced any definitive answers yet
|
Merging the changes here so that subsequent pull requests will run with the full intended list of operating systems. Investigation into the test failures for Py3.10 / Py3.11 on MacOS continues in #629. |
…t failure noted at #628 (comment) bug could have been introduced Attempted reading and comparing the 3.10.x and 3.11.x changelogs since the failure affects both lineages of Python, but that hasn't produced any definitive answers yet
| @@ -10,11 +10,18 @@ on: | |||
|
|
|||
| jobs: | |||
| test: | |||
| runs-on: ubuntu-latest | |||
There was a problem hiding this comment.
that's been pretty lame on my part 😅
Resolves #627