Use isodate library to attempt ISO 8601 duration parsing in get_minutes #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: we already currently depend on this library implicitly; it is required by rdflib which is required by extruct
…hat look like potential ISO8601 date strings in get_minutes utility method
Refactoring and simplification would be useful here
|
Do you know what features this specifically brings us compared to the standard library implementation? I don't necessarily mind formalizing a transitive dependency, but I have a (highly subjective) bias to using the stdlib when possible and ergonomic to. |
|
@bfcarpio agreed - I share the same preference for the standard library when possible too. Currently in the Python 3.10 stdlib, only It's possible that this functionality may appear in Python at some point, though... python/cpython#86260 exists tracking that as a request. |
bfcarpio
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
isodatelibrary to attempt to parse time durations from strings that look like potential ISO8601 date strings inget_minutesutility method.Note that we already transitively depend on the
isodatelibrary (viaextruct -> rdflib -> isodate).The
get_minutesmethod began failing aflake8complexity check after this functionality was added; that method would benefit from some simplification and refactoring (see #551).Fixes #606.