Raise an exception when field information is not provided by a host

recipe_scrapers/_abstract.py

@@ -1,4 +1,4 @@
-# mypy: allow-untyped-defs
+# mypy: disallow_untyped_defs=False
 
 from abc import ABC, abstractmethod
 from collections import OrderedDict

recipe_scrapers/_exceptions.py

@@ -1,4 +1,5 @@
 # mypy: disallow_untyped_defs=False
+
 class RecipeScrapersExceptions(Exception):
     def __init__(self, message):
         self.message = message

recipe_scrapers/coop.py

@@ -1,4 +1,5 @@
 # mypy: disallow_untyped_defs=False
+
 from ._abstract import AbstractScraper
 
 
@@ -17,8 +18,7 @@ def category(self):
         return self.schema.category()
 
     def total_time(self):
-        # TODO: add implementation
-        raise NotImplementedError("This should be implemented.")
+        return self.schema.total_time()
 
     def cook_time(self):
         return self.schema.cook_time()

recipe_scrapers/davidlebovitz.py

@@ -1,5 +1,7 @@
 # mypy: disallow_untyped_defs=False
+
 from ._abstract import AbstractScraper
+from ._exceptions import RecipeScrapersExceptions
 
 
 class DavidLebovitz(AbstractScraper):
@@ -14,8 +16,7 @@ def title(self):
         return self.schema.title()
 
     def total_time(self):
-        # TODO: add implementation
-        raise NotImplementedError("This should be implemented.")
+        raise RecipeScrapersExceptions(f"{self.host} does not provide time information.")
 
     def image(self):
         return self.schema.image()

recipe_scrapers/farmhousedelivery.py

@@ -1,9 +1,11 @@
 # mypy: disallow_untyped_defs=False
+
 import re
 
 from bs4 import Tag
 
 from ._abstract import AbstractScraper
+from ._exceptions import RecipeScrapersExceptions
 from ._utils import normalize_string
 
 """
@@ -21,8 +23,7 @@ def title(self):
         return self.soup.find("h1", {"class": "entry-title"}).get_text(strip=True)
 
     def total_time(self):
-        # TODO: add implementation
-        raise NotImplementedError("This should be implemented.")
+        raise RecipeScrapersExceptions(f"{self.host} does not provide time information.")
 
     def ingredients(self):
         # Style 1

recipe_scrapers/fredriksfikaallas.py

@@ -1,7 +1,9 @@
 # mypy: disallow_untyped_defs=False
+
 import re
 
 from ._abstract import AbstractScraper
+from ._exceptions import RecipeScrapersExceptions
 
 
 class FredriksFikaAllas(AbstractScraper):
@@ -25,8 +27,7 @@ def category(self):
         )
 
     def total_time(self):
-        # TODO: add implementation
-        raise NotImplementedError("This should be implemented.")
+        raise RecipeScrapersExceptions(f"{self.host} does not provide time information.")
 
     def image(self):
         return self.schema.image()

recipe_scrapers/kuchniadomowa.py

@@ -1,5 +1,7 @@
 # mypy: disallow_untyped_defs=False
+
 from ._abstract import AbstractScraper
+from ._exceptions import RecipeScrapersExceptions
 
 
 class KuchniaDomowa(AbstractScraper):
@@ -11,8 +13,7 @@ def title(self):
         return self.soup.find("h2").get_text().strip()
 
     def total_time(self):
-        # TODO: add implementation
-        raise NotImplementedError("This should be implemented.")
+        return self.schema.total_time()
 
     def image(self):
         urls = self.soup.findAll("img", {"class": "article-img", "id": "article-img-1"})

recipe_scrapers/kwestiasmaku.py

@@ -1,5 +1,7 @@
 # mypy: disallow_untyped_defs=False
+
 from ._abstract import AbstractScraper
+from ._exceptions import RecipeScrapersExceptions
 from ._utils import get_yields, normalize_string
 
 
@@ -17,8 +19,7 @@ def title(self):
         return normalize_string(self.soup.find("div", {"itemprop": "name"}).get_text())
 
     def total_time(self):
-        # TODO: add implementation
-        raise NotImplementedError("This should be implemented.")
+        raise RecipeScrapersExceptions(f"{self.host} does not provide time information.")
 
     def yields(self):
         return get_yields(

recipe_scrapers/maangchi.py

@@ -1,6 +1,7 @@
 # mypy: allow-untyped-defs
 
 from ._abstract import AbstractScraper
+from ._exceptions import RecipeScrapersExceptions
 from ._utils import normalize_string
 
 
@@ -19,8 +20,7 @@ def category(self):
         return self.schema.category()
 
     def total_time(self):
-        # TODO: add implementation
-        raise NotImplementedError("This should be implemented.")
+        raise RecipeScrapersExceptions(f"{self.host} does not provide time information.")
 
     def yields(self):
         return self.schema.yields()

recipe_scrapers/mykitchen101.py

@@ -1,9 +1,11 @@
 # mypy: disallow_untyped_defs=False
+
 import re
 
 from bs4 import BeautifulSoup
 
 from ._abstract import AbstractScraper
+from ._exceptions import RecipeScrapersExceptions
 from ._utils import get_yields, normalize_string
 
 
@@ -19,8 +21,7 @@ def title(self):
         return self.soup.find("h1", {"class": "entry-title"}).get_text()
 
     def total_time(self):
-        # TODO: add implementation
-        raise NotImplementedError("This should be implemented.")
+        raise RecipeScrapersExceptions(f"{self.host} does not provide time information.")
 
     def yields(self):
         return get_yields(self.soup.find("p", string=re.compile("分量：")).get_text())

recipe_scrapers/mykitchen101en.py

@@ -1,9 +1,11 @@
 # mypy: disallow_untyped_defs=False
+
 import re
 
 from bs4 import BeautifulSoup
 
 from ._abstract import AbstractScraper
+from ._exceptions import RecipeScrapersExceptions
 from ._utils import get_yields, normalize_string
 
 
@@ -19,8 +21,7 @@ def title(self):
         return self.soup.find("h1", {"class": "entry-title"}).get_text()
 
     def total_time(self):
-        # TODO: add implementation
-        raise NotImplementedError("This should be implemented.")
+        raise RecipeScrapersExceptions(f"{self.host} does not provide time information.")
 
     def yields(self):
         return get_yields(self.soup.find("p", string=re.compile("Yields: ")).get_text())

recipe_scrapers/owenhan.py

@@ -1,5 +1,7 @@
 # mypy: disallow_untyped_defs=False
+
 from ._abstract import AbstractScraper
+from ._exceptions import RecipeScrapersExceptions
 
 
 class OwenHan(AbstractScraper):
@@ -14,8 +16,7 @@ def title(self):
         return self.soup.find("h1", {"class": "entry-title"}).text
 
     def total_time(self):
-        # TODO: add implementation
-        raise NotImplementedError("This should be implemented.")
+        raise RecipeScrapersExceptions(f"{self.host} does not provide time information.")
 
     def image(self):
         return self.schema.image()

recipe_scrapers/rosannapansino.py

@@ -1,6 +1,7 @@
 # mypy: allow-untyped-defs
 
 from ._abstract import AbstractScraper
+from ._exceptions import RecipeScrapersExceptions
 from ._utils import normalize_string
 
 
@@ -13,8 +14,7 @@ def title(self):
         return self.soup.find("meta", {"property": "og:title"})["content"]
 
     def total_time(self):
-        # TODO: add implementation
-        raise NotImplementedError("This should be implemented.")
+        raise RecipeScrapersExceptions(f"{self.host} does not provide time information.")
 
     def image(self):
         return self.schema.image()

tests/test_davidlebovitz.py

@@ -1,3 +1,4 @@
+from recipe_scrapers._exceptions import RecipeScrapersExceptions
 from recipe_scrapers.davidlebovitz import DavidLebovitz
 from tests import ScraperTest
 
@@ -15,6 +16,9 @@ def test_author(self):
     def test_title(self):
         self.assertEqual("Faux Gras", self.harvester_class.title())
 
+    def test_total_time(self):
+        self.assertRaises(RecipeScrapersExceptions, self.harvester_class.total_time)
+
     def test_image(self):
         self.assertEqual(
             "https://www.davidlebovitz.com/wp-content/uploads/2015/06/Faux-Gras-Lentil-Pate-8.jpg",

tests/test_farmhousedelivery_1.py

@@ -1,3 +1,4 @@
+from recipe_scrapers._exceptions import RecipeScrapersExceptions
 from recipe_scrapers.farmhousedelivery import FarmhouseDelivery
 from tests import ScraperTest
 
@@ -19,6 +20,9 @@ def test_canonical_url(self):
     def test_title(self):
         self.assertEqual("Green Shakshuka", self.harvester_class.title())
 
+    def test_total_time(self):
+        self.assertRaises(RecipeScrapersExceptions, self.harvester_class.total_time)
+
     def test_ingredients(self):
         self.assertEqual(
             [

tests/test_farmhousedelivery_2.py

@@ -1,3 +1,4 @@
+from recipe_scrapers._exceptions import RecipeScrapersExceptions
 from recipe_scrapers.farmhousedelivery import FarmhouseDelivery
 from tests import ScraperTest
 
@@ -22,6 +23,9 @@ def test_title(self):
             self.harvester_class.title(),
         )
 
+    def test_total_time(self):
+        self.assertRaises(RecipeScrapersExceptions, self.harvester_class.total_time)
+
     def test_ingredients(self):
         self.assertEqual(
             [

tests/test_fredriksfikaallas.py

@@ -1,3 +1,4 @@
+from recipe_scrapers._exceptions import RecipeScrapersExceptions
 from recipe_scrapers.fredriksfikaallas import FredriksFikaAllas
 from tests import ScraperTest
 
@@ -15,6 +16,9 @@ def test_author(self):
     def test_title(self):
         self.assertEqual("Mormors bästa tekakor", self.harvester_class.title())
 
+    def test_total_time(self):
+        self.assertRaises(RecipeScrapersExceptions, self.harvester_class.total_time)
+
     def test_category(self):
         self.assertEqual("Fredriks bröd", self.harvester_class.category())
 

tests/test_mykitchen101.py

@@ -1,3 +1,4 @@
+from recipe_scrapers._exceptions import RecipeScrapersExceptions
 from recipe_scrapers.mykitchen101 import MyKitchen101
 from tests import ScraperTest
 
@@ -15,6 +16,9 @@ def test_author(self):
     def test_title(self):
         self.assertEqual("古早味迷你烤鸡蛋糕", self.harvester_class.title())
 
+    def test_total_time(self):
+        self.assertRaises(RecipeScrapersExceptions, self.harvester_class.total_time)
+
     def test_yields(self):
         self.assertEqual("30 servings", self.harvester_class.yields())
 

tests/test_mykitchen101en.py

@@ -1,3 +1,4 @@
+from recipe_scrapers._exceptions import RecipeScrapersExceptions
 from recipe_scrapers.mykitchen101en import MyKitchen101en
 from tests import ScraperTest
 
@@ -15,6 +16,9 @@ def test_author(self):
     def test_title(self):
         self.assertEqual("Mini Baked Egg Sponge Cakes", self.harvester_class.title())
 
+    def test_total_time(self):
+        self.assertRaises(RecipeScrapersExceptions, self.harvester_class.total_time)
+
     def test_yields(self):
         self.assertEqual("30 servings", self.harvester_class.yields())
 

tests/test_owenhan.py

@@ -1,3 +1,4 @@
+from recipe_scrapers._exceptions import RecipeScrapersExceptions
 from recipe_scrapers.owenhan import OwenHan
 from tests import ScraperTest
 
@@ -15,6 +16,9 @@ def test_host(self):
     def test_title(self):
         self.assertEqual("Chicken Bacon Ranch", self.harvester_class.title())
 
+    def test_total_time(self):
+        self.assertRaises(RecipeScrapersExceptions, self.harvester_class.total_time)
+
     def test_image(self):
         self.assertEqual(
             "http://static1.squarespace.com/static/627be79397093e2de753b260/627c408602fed77ca384eb11/63120c4090e9bf706973d712/1662127792157/IMG_2037.jpg?format=1500w",

tests/test_rosannapansino.py

@@ -1,5 +1,6 @@
 # mypy: allow-untyped-defs
 
+from recipe_scrapers._exceptions import RecipeScrapersExceptions
 from recipe_scrapers.rosannapansino import RosannaPansino
 from tests import ScraperTest
 
@@ -14,6 +15,9 @@ def test_host(self):
     def test_title(self):
         self.assertEqual("Marshmallow Fondant", self.harvester_class.title())
 
+    def test_total_time(self):
+        self.assertRaises(RecipeScrapersExceptions, self.harvester_class.total_time)
+
     def test_image(self):
         self.assertEqual(
             "http://cdn.shopify.com/s/files/1/0163/5948/9636/articles/1Y6A6281_grande.jpg?v=1567109086",