Add 'python_requires=">=3.6"' to match tomli package #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding a dependency on the `tomli` packages, which only has versions available for python >=3.6 (>=3.7 for the lastest version at the moment), `autopep8` effectively became compatible with python >=3.6 also. This changes reflects that by properly providing the `Requires-Python` package metadata (https://packaging.python.org/en/latest/guides/dropping-older-python-versions/#specify-the-version-ranges-for-supported-python-distributions).
Codecov ReportBase: 98.12% // Head: 98.12% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 1 1
Lines 2403 2403
=======================================
Hits 2358 2358
Misses 45 45 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding a dependency on the
tomlipackages, which only has versions available for python >=3.6 (>=3.7 for the lastest version at the moment),autopep8effectively became compatible with only python >=3.6 also.This changes reflects that by properly providing the
Requires-Pythonpackage metadata(https://packaging.python.org/en/latest/guides/dropping-older-python-versions/#specify-the-version-ranges-for-supported-python-distributions).
Note for maintainers: After merging and releasing this, you would need to yank the
autopep81.7.1 release*, so that python 2 environments stop attempting to install that incompatible version. From that point on, you would be safe and free to keep going py3 only withtout impacting py2 users anymore.This will make the life of those still using python 2 (or stuck maintaining stuff on it due to unfortunate circumstances out of their control... cough cough) that much easier.
* edit: I now see that you have made a 2.0.0 tag release, which hasn't landed on pypi yet, and with the intent of yanking 1.7.1. You'll need to also yank that 2.0.0 and make a 2.0.1 release with this fix, or something like that. With all those suggestions said, I'll now let you manage your project 😄 .
This addresses issue #655 .
Thanks and cheers!