Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: autoupdate hook versions #1411

Merged
merged 3 commits into from Dec 9, 2021
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 7, 2021

Base PullRequest

default branch (https://github.com/hgrecco/pint/tree/master)

Command results

Details:
add path
/home/runner/work/_actions/technote-space/create-pr-action/bfd4392c80dbeb54e0bacbcf4750540aecae6ed4/node_modules/npm-check-updates/bin
python -m pre_commit autoupdate
Updating https://github.com/psf/black ... [INFO] Initializing environment for https://github.com/psf/black.
updating 21.9b0 -> 21.10b0.
Updating https://github.com/pycqa/isort ... [INFO] Initializing environment for https://github.com/pycqa/isort.
updating 5.9.3 -> 5.10.0.
Updating https://gitlab.com/pycqa/flake8 ... already up to date.
python -m pre_commit run --all-files
[INFO] Installing environment for https://github.com/psf/black.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pycqa/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://gitlab.com/pycqa/flake8.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
black....................................................................Passed
isort....................................................................Passed
flake8...................................................................Passed

Changed files

Changed file:
  • .pre-commit-config.yaml

:octocat: Repo | 📝 Issues | 🏬 Marketplace

@github-actions
Copy link
Contributor Author

Command results

Details:
add path
/home/runner/work/_actions/technote-space/create-pr-action/bfd4392c80dbeb54e0bacbcf4750540aecae6ed4/node_modules/npm-check-updates/bin
python -m pre_commit autoupdate
Updating https://github.com/psf/black ... [INFO] Initializing environment for https://github.com/psf/black.
already up to date.
Updating https://github.com/pycqa/isort ... [INFO] Initializing environment for https://github.com/pycqa/isort.
updating 5.10.0 -> 5.10.1.
Updating https://gitlab.com/pycqa/flake8 ... already up to date.
python -m pre_commit run --all-files
[INFO] Installing environment for https://github.com/psf/black.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pycqa/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://gitlab.com/pycqa/flake8.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
black....................................................................Passed
isort....................................................................Passed
flake8...................................................................Passed

Changed files

Changed file:
  • .pre-commit-config.yaml

:octocat: Repo | 📝 Issues | 🏬 Marketplace

@github-actions
Copy link
Contributor Author

Command results

Details:
add path
/home/runner/work/_actions/technote-space/create-pr-action/bfd4392c80dbeb54e0bacbcf4750540aecae6ed4/node_modules/npm-check-updates/bin
python -m pre_commit autoupdate
Updating https://github.com/psf/black ... [INFO] Initializing environment for https://github.com/psf/black.
updating 21.10b0 -> 21.11b1.
Updating https://github.com/pycqa/isort ... [INFO] Initializing environment for https://github.com/pycqa/isort.
already up to date.
Updating https://gitlab.com/pycqa/flake8 ... already up to date.
python -m pre_commit run --all-files
[INFO] Installing environment for https://github.com/psf/black.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pycqa/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://gitlab.com/pycqa/flake8.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
black....................................................................Passed
isort....................................................................Passed
flake8...................................................................Passed

Changed files

Changed file:
  • .pre-commit-config.yaml

:octocat: Repo | 📝 Issues | 🏬 Marketplace

@keewis
Copy link
Contributor

keewis commented Dec 9, 2021

just for reference, in xarray we abandoned this workflow and started using pre-commit.ci... so far it works really well.

@hgrecco
Copy link
Owner

hgrecco commented Dec 9, 2021

@keewis can you write briefly what are the differences?

@keewis
Copy link
Contributor

keewis commented Dec 9, 2021

sure. Compare pydata/xarray#5949 and pydata/xarray#5955:

  1. from a technical perspective they are different things: the previous one was a workflow while pre-commit.ci is a "app". This is especially visible with the other workflows: the "app" triggers the other CI while the workflow doesn't (would have been possible to add / configure, but I was not motivated enough for that)
  2. which leads to another advantage: we don't have to maintain it (which is both good and bad, I guess – bad as in "if something breaks we have to wait on the maintainers to fix it")
  3. the error reporting is much better: with the workflow you have to actively check the results (hidden in a details box), while with pre-commit.ci a green check mark indicates no CI failures.
  4. it will automatically delete branches of PRs that have been merged / closed, while with the workflow you had to manually do that (otherwise it would create a new PR even if there were no changes). I guess bors is taking care of that, too.
  5. it has additional features, like a "autocorrect" bot which commits autoformatter fixes (i.e. black and isort) to the branches (can be disabled if you don't like it, though)

I'd say 2 and 3 are especially important.

@jules-ch jules-ch merged commit f287768 into master Dec 9, 2021
@bors bors bot deleted the pre-commit/autoupdate-0 branch December 9, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants