Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(deploy): add an overview page #1211

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Nov 9, 2019

Check List

Please read and check followings before submitting a PR.

  • I want to publish my theme on Hexo official website.
    • I have read the theme publishing doc.
    • name is unique.
    • link URL is correct.
    • preview URL is correct.
    • preview URL web site is rendered correctly.
    • Add a screenshot to source/themes/screenshots.
    • Screenshot filename is same as value of name.
    • Screenshot size is 800 * 500.
    • Screenshot file format is png.
  • I want to publish my plugin on Hexo official website.
  • Others (Update, fix, translation, etc...)

The original idea came from here. This PR adds a deployment overview page. Demo can be found at Netlify and pages will only be copied to other lang's directories after everyone is happy with the PR.

@SukkaW SukkaW requested review from NoahDragon, yoshinorin, curbengh and a team November 9, 2019 13:37
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO Deployment -> Deployment section is not good naming. How do you think?

deployment

On localhost [Read More](...) return 404. I confirmed it works well on the Netlify.

localhost

@SukkaW
Copy link
Member Author

SukkaW commented Nov 13, 2019

@yoshinorin The exact path of GitHub Pages guide should be /docs/github-pages.html and Netlify can serve the page without the suffix .html.

@yoshinorin
Copy link
Member

@SukkaW

The exact path of GitHub Pages guide should be /docs/github-pages.html and Netlify can serve the page without the suffix .html.

Yes :)

I think this behavior will solve if we implement this feature.

I will try to it this weekend if I have a time.

@SukkaW
Copy link
Member Author

SukkaW commented Nov 13, 2019

image

I found out the <h2> & <h3> tags only have small difference.

@NoahDragon
Copy link
Member

I agree with @yoshinorin that deployment -> deployment is a bit repetitive, but I don't have any good idea so far. Other than it, everything is great. Thanks for gathering those deployment methods together.

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SukkaW
Would you please copy it to other languages?

I can't review the Chinese doc. So, after add Chinese docs we have to ask to review to @NoahDragon, @curbengh again.


I found out the <h2> & <h3> tags only have small difference.

I think we can improve the official site design more :)

@SukkaW
Copy link
Member Author

SukkaW commented Nov 19, 2019

Please do not merge this PR. I might bring up some style changes.

After everyone happy with the coming style changes then would I copy it to all the languages.

@SukkaW SukkaW changed the title docs(deploy): add a overview page [WIP] docs(deploy): add a overview page Nov 19, 2019
@stevenjoezhang stevenjoezhang marked this pull request as draft August 17, 2020 16:56
@stevenjoezhang stevenjoezhang changed the title [WIP] docs(deploy): add a overview page [WIP] docs(deploy): add an overview page Jul 28, 2023
@stevenjoezhang stevenjoezhang changed the title [WIP] docs(deploy): add an overview page docs(deploy): add an overview page Jul 28, 2023
@stevenjoezhang
Copy link
Member

It's able to merge after checking #1539

@stevenjoezhang
Copy link
Member

To make the document clearer, the difference between Deployer Plugins and Platforms is as follows: Deployer Plugins are plugins that allow users to compile locally and publish a blog using the 'hexo d' command. On the other hand, Platforms are more similar to providing CI/CD services.

@stevenjoezhang stevenjoezhang marked this pull request as ready for review September 6, 2023 01:24
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

Theme name validation passed.
Theme thumbnails validation completed.

@uiolee
Copy link
Member

uiolee commented Sep 11, 2023

deployment

maybe we can name it overview

@stevenjoezhang
Copy link
Member

We also need to create this page in other languages, or it will result in a 404 error.

@tomap
Copy link
Contributor

tomap commented Oct 10, 2023

We also need to create this page in other languages, or it will result in a 404 error.

Or we could change the i18n plugin to redirect to home is the page in the other language does not exists?

@uiolee
Copy link
Member

uiolee commented Oct 11, 2023

Or we could change the i18n plugin to redirect to home is the page in the other language does not exists?

If wanna do that, I think we could redirect to the corresponding English page likes mdn do.

@uiolee uiolee added Docs source/docs en lang: en labels Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs source/docs en lang: en
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants