Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#4917): suppress YAMLException when load js-yaml (backport: #4927) #4929

Closed
wants to merge 1 commit into from
Closed

fix(#4917): suppress YAMLException when load js-yaml (backport: #4927) #4929

wants to merge 1 commit into from

Conversation

yoshinorin
Copy link
Member

This PR is backport from #4927
I'm going to release a patch version (5.4.2) after merge this PR.

Thank you :)

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

SukkaW
SukkaW requested changes Apr 5, 2022
View reviewed changes
Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that js-yaml-types just use String.prototype.matchAll which is not yet supported until Node.js 16.

What about downgrade js-yaml version for Hexo 5.4.2?

@yoshinorin
Copy link
Member Author

What about downgrade js-yaml version for Hexo 5.4.2?

Thank you :)
OK, I will close & submit new PR.

which is not yet supported until Node.js 16.

BTW, should we downgrade it version for 6.x.x?
The hexo 6.x.x supports Node 12, 14 and 16.

@yoshinorin yoshinorin closed this Apr 6, 2022
@yoshinorin yoshinorin deleted the backport-4927 branch April 6, 2022 12:49
@yoshinorin yoshinorin mentioned this pull request Apr 6, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yoshinorin @SukkaW