Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/test: use chai#should #4902

Merged
merged 1 commit into from Feb 25, 2022
Merged

chore/test: use chai#should #4902

merged 1 commit into from Feb 25, 2022

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Feb 24, 2022

What does it do?

This deprecates the old require('chai/register-should') which causes the test to fail.

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@github-actions
Copy link

How to test

git clone -b chai-register-should https://github.com/SukkaW/hexo.git
cd hexo
npm install
npm test

yoshinorin
yoshinorin approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SukkaW SukkaW merged commit 3e3c4ba into hexojs:master Feb 25, 2022
@SukkaW SukkaW mentioned this pull request Feb 25, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SukkaW @yoshinorin @stevenjoezhang