Replace Stream.readable.pipe()
with data
event API in getHash()
#4292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fix one of errors of the issue #3818. (#3818 (comment))
With Node.js v10.x,
npm test
fails some times.One of them is
process() - skip (mtime changed but hash matched):
as follows:This patch fixes this error.
I found that a combination
Stream.readable.pipe()
andCrypt.createHash()
causes this error.By replacing
Stream.readable.pipe()
withdata
event API, this error is resolved.But I can not explain why this replacing does resolve this error.
How to test
Pull request tasks