Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: drop hexo-util#HashStream #4279

Merged
merged 1 commit into from Apr 27, 2020
Merged

refactor: drop hexo-util#HashStream #4279

merged 1 commit into from Apr 27, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Apr 27, 2020 •
edited

What does it do?

hexo-util#HashStream has already deprecated and is removed in hexojs/hexo-util#198. This PR drop the usage of it.

How to test

git clone -b drop-hashstream https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW
refactor: drop hexo-util#HashStream
c41fd7d 
Replace with hexo-util#createSha1Hash
@SukkaW SukkaW requested review from stevenjoezhang, curbengh and a team April 27, 2020 14:43
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.742% when pulling c41fd7d on SukkaW:drop-hashstream into a432aee on hexojs:master.

@SukkaW SukkaW merged commit 5c6985a into hexojs:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

@curbengh curbengh Awaiting requested review from curbengh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SukkaW @coveralls @stevenjoezhang