Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(load_plugins): make sure file is created #4265

Merged
merged 1 commit into from
Apr 25, 2020
Merged

test(load_plugins): make sure file is created #4265

merged 1 commit into from
Apr 25, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Apr 24, 2020

What does it do?

Fix potential race condition causing test to fail. Discovered in #4264.

How to test

git clone -b test-load-plugins https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW marked this pull request as ready for review April 24, 2020 10:32
@SukkaW SukkaW merged commit 6d29793 into hexojs:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

@curbengh curbengh Awaiting requested review from curbengh

@jiangtj jiangtj Awaiting requested review from jiangtj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SukkaW @stevenjoezhang