Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: space for asyncArrow #4102

Merged
merged 1 commit into from Feb 8, 2020
Merged

style: space for asyncArrow #4102

merged 1 commit into from Feb 8, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Jan 27, 2020

What does it do?

hexojs/eslint-config-hexo#28

How to test

git clone -b style-async-fun-space https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW requested review from curbengh and a team and removed request for curbengh January 27, 2020 06:27
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.701% when pulling 2c80b5e on SukkaW:style-async-func-space into 667d9a0 on hexojs:master.

@SukkaW SukkaW mentioned this pull request Jan 31, 2020
Merged
2 tasks
segayuu
segayuu approved these changes Feb 8, 2020
View reviewed changes
Copy link
Contributor

@segayuu segayuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@segayuu segayuu merged commit 3824b59 into hexojs:master Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segayuu segayuu segayuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SukkaW @coveralls @segayuu