Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(benchmark): skip checking completion time in hot processing #3993

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Dec 19, 2019

What does it do?

After #3991, the CI on master branch is failing because the hot processing takes less than 10 seconds.

This PR skips completion time and line number checking in hot processing.

How to test

git clone -b benchmark-hot-processing https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Dec 19, 2019

Coverage Status

Coverage remained the same at 97.111% when pulling 88506bc on curbengh:benchmark-hot-processing into 91e5c32 on hexojs:master.

@dailyrandomphoto
Copy link
Member

We should focus on improving performance for bigger sites.
How about adding more posts to the benchmark site. (300 => 500 or 1000)
The larger the site, the more noticeable the change in performance.

@SukkaW
Copy link
Member

SukkaW commented Dec 20, 2019

@dailyrandomphoto
The benchmark performed by CI should be considered as a part of a unit test, to see if there is any performance regression or gained through each commit. So we'd like to have a relatively small site with 300 posts so that each build could be finished in 2 minutes.

As you can see in #3941 & #3812, performance regression is already noticeable enough.

@SukkaW SukkaW merged commit 3b58c63 into hexojs:master Dec 20, 2019
@dailyrandomphoto
Copy link
Member

Ok, I see.

@curbengh curbengh deleted the benchmark-hot-processing branch December 20, 2019 02:46
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants