Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(external_link): utilize isExternalLink() of hexo-util #3835

Closed
wants to merge 1 commit into from
Closed

refactor(external_link): utilize isExternalLink() of hexo-util #3835

wants to merge 1 commit into from

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Nov 5, 2019

What does it do?

How to test

git clone -b is-external https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 97.118% when pulling 86b1b2f on curbengh:is-external into 77f3e21 on hexojs:master.

@curbengh curbengh added this to In progress in Drop legacy URL API via automation Nov 5, 2019
@curbengh curbengh moved this from In progress to To do in Drop legacy URL API Nov 5, 2019
@curbengh
Copy link
Contributor Author

curbengh commented Nov 5, 2019

In relation #3833, this still uses whatwg. Cold processing time in Node 13 is 80s.

Using legacy api (#3834) drops it to 27s (which is a normal duration).

@SukkaW SukkaW mentioned this pull request Nov 5, 2019
Closed
@curbengh
Copy link
Contributor Author

curbengh commented Nov 9, 2019

hexojs/hexo-util#124 #3839

@curbengh curbengh closed this Nov 9, 2019
Drop legacy URL API automation moved this from To do to Done Nov 9, 2019
@curbengh curbengh deleted the is-external branch November 9, 2019 03:41
@SukkaW SukkaW mentioned this pull request Nov 9, 2019
Closed
2 tasks
@SukkaW SukkaW mentioned this pull request Nov 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Drop legacy URL API
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@curbengh @coveralls