Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(new_post_path): revert to lodash defaults #3831

Closed
wants to merge 5 commits into from
Closed

perf(new_post_path): revert to lodash defaults #3831

wants to merge 5 commits into from

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Nov 5, 2019 •
edited

What does it do?

From the CI benchmark, cold run usually finished within 25 seconds, lately I noticed it has increased to a minute.

How to test

git clone -b revert-lodash-defaults https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Nov 5, 2019 •
edited

Coverage Status

Coverage decreased (-0.002%) to 97.141% when pulling 8a475a8 on curbengh:revert-lodash-defaults into 77f3e21 on hexojs:master.

@curbengh curbengh mentioned this pull request Nov 5, 2019
Closed
@curbengh
Copy link
Contributor Author

curbengh commented Nov 9, 2019

hexojs/hexo-util#124 #3839

@curbengh curbengh closed this Nov 9, 2019
@curbengh curbengh deleted the revert-lodash-defaults branch November 9, 2019 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@curbengh @coveralls