Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: allow empty attribute #3648

Closed
wants to merge 1 commit into from
Closed

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Aug 4, 2019

What does it do?

asset_img() and link() utilize hexo-util. hexojs/hexo-util#36 introduced a change, where empty attributes (attribute without any value) are retained, instead of being removed.

This PR modifies the test cases to adapt to new behavior of hexo-util@1.0.0.

How to test

git clone -b unit-test https://github.com/curbengh/hexo.git
cd hexo
package.json:
- "hexo-util": "^0.6.3",
+ "hexo-util": "1.0.0-rc1",
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.
    • Will only pass after hexo starts using hexo-util@1.0.0.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.152% when pulling 6b395fc on curbengh:unit-test into 9b87047 on hexojs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.152% when pulling 6b395fc on curbengh:unit-test into 9b87047 on hexojs:master.

@curbengh
Copy link
Contributor Author

curbengh commented Aug 7, 2019

Merged into #3646

@curbengh curbengh closed this Aug 7, 2019
@curbengh curbengh deleted the unit-test branch August 7, 2019 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants