Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(appveyor): replace node 11 with 12 #3603

Merged
merged 1 commit into from
Jul 1, 2019
Merged

chore(appveyor): replace node 11 with 12 #3603

merged 1 commit into from
Jul 1, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Jun 29, 2019 •
edited

What does it do?

appveyor supports node 12 since 2019-06-14.
v11 is EOL since 2019-06-01.

How to test

git clone -b node-12 https://github.com/weyusi/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Passed the CI test.

@curbengh
Copy link
Contributor Author

Let me know if this should be part of #3598.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.148% when pulling 1f7fe5f on weyusi:node-12 into 7fba3c1 on hexojs:master.

yoshinorin
yoshinorin approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 😄

@yoshinorin yoshinorin merged commit fe107a1 into hexojs:master Jul 1, 2019
@curbengh curbengh deleted the node-12 branch July 1, 2019 10:33
@yoshinorin yoshinorin added this to the v4.0.0 milestone Jul 6, 2019
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
@curbengh
chore(appveyor): replace node 11 with 12 (hexojs#3603)
0064309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@curbengh @coveralls @yoshinorin @weyusi