Allow backtick code block in "blockquote" tag plugin (#2318) #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When backtick code block(s) exist as contents of a "blockquote" tag plugin, each code block is translated to a string "undefined" in HTML (Issue hexojs#2318). In analyzing markdown source text, while the replacement of these elements with placeholders are nesting, recoveries from placeholders are executed only once. So I modify to repeat the recovery process until all placeholders are recovered.
|
Just curious, why close this PR? |
|
@NoahDragon This PR was just replaced with #2321. I'm sorry that I made a new PR instead of updating this PR. I was inexperienced in GitHub at that time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When backtick code block(s) exist as contents of a "blockquote" tag plugin,
each code block is translated to a string "undefined" in HTML (Issue #2318).
In analyzing markdown source text, while the replacement of these elements
with placeholders are nesting, recoveries from placeholders are executed
only once. So I modify to repeat the recovery process until all
placeholders are recovered.