Allow backtick code block in "blockquote" tag plugin (#2318) #2321

seaoak · 2016-12-19T11:20:53Z

When backtick code block(s) exist as contents of a "blockquote" tag plugin,
each code block is translated to a string "undefined" in HTML (Issue #2318).

In analyzing markdown source text, while the replacement of these elements
with placeholders are nesting, recoveries from placeholders are executed
only once. So I modify to repeat the recovery process until all
placeholders are recovered.

NOTE: From Pull Request #2319, I correct the condition of exception (accept empty string as escape content).

coveralls · 2016-12-19T11:22:17Z

Coverage increased (+0.005%) to 97.278% when pulling 11c032b on seaoak:feature/allow-backtick-code-block-in-blockquote-tag-plugin into bd70086 on hexojs:master.

NoahDragon · 2016-12-19T17:05:35Z

Could you please also add the test case for it?

ivan-nginx

BTW, all tags which have ends: true parameter not working correctly in each other. For example, codeblock also won't work in note (bscallout) tag.

This pull usefull and non merged from 19 Dec 2016. Is this +0.008% coverage so important to freeze bug for 1.5 years?

curbengh · 2018-10-30T02:37:57Z

@seaoak post.js has significantly changed, please rebase.

yoshinorin · 2018-11-10T21:29:39Z

@weyusi @NoahDragon @hexojs/core
I tried to rebase this PR to master.
But, current post.js source code changed drastic compare with this PR.

I propose we re-create other PR instead of this PR if @seaoak will not react our mention.

tcrowe · 2018-11-10T21:47:11Z

Good idea @yoshinorin

curbengh · 2018-11-12T07:00:03Z

@yoshinorin
if someone can port this PR to the current post.js that would be great. Before I ping @seaoak, I also tried to re-base, but too bad it's beyond me.

I think the resursion function could fix #3318 #2821

seaoak · 2018-11-12T11:53:05Z

Sorry, I'm too late to response you.
I thank you for picking up this PR!

I was busy over the past year, but quite recently I have a little time to enjoy programming.
If allowed, I'll try to rebase this PR.
Of course, I should catch up with current codes of Hexo.
So it may need about a month or more...

If anymone takes this PR, I'm pleased to leave this PR. 😄

yoshinorin · 2018-11-13T08:18:39Z

Welcome back seaoka !!
It’s okay. Please don't worry, we patiently waiting for your PR 😄

JLHwung · 2018-12-01T14:10:17Z

@seaoak Please resolve the conflict.

stevenjoezhang · 2019-09-30T14:35:07Z

Any updates on this thread?

When backtick code block(s) exist as contents of a "blockquote" tag plugin, each code block is translated to a string "undefined" in HTML (Issue hexojs#2318). In analyzing markdown source text, while the replacement of these elements with placeholders are nesting, recoveries from placeholders are executed only once. So I modify to repeat the recovery process until all placeholders are recovered.

seaoak · 2019-10-10T05:31:01Z

I'm sorry I restarted to catch up latest Hexo last month.
I had left from Hexo development for a long time,
it will take a while.

I'll be glad if you give me a chance to update this patch.

seaoak · 2019-10-11T20:53:26Z

I rewrite this patch for latest Hexo.
And also add a test case for this patch.

@hexojs/core Could you please review?

By the way #3318 is not fixed by this patch.
It seems like #2969.

NOTE:
I did "forced push" to this branch because the code base of Hexo changed drastically.
If it violates the common manner, I will make new PR (and close this PR).

seaoak · 2019-10-12T03:16:40Z

Travis CI erros only on Node.js 6.x.
The Build options of this PR might be too old.

May I adjust build options of this PR? (Although I'm not familiar with Travis CI...)

SukkaW · 2019-10-12T05:28:26Z

@sseaoak We have already drop node 6 for Travis CI in #3598

I will trigger a rebuild for you.

curbengh · 2019-10-12T06:27:24Z

NOTE:
I did "forced push" to this branch because the code base of Hexo changed drastically.
If it violates the common manner, I will make new PR (and close this PR).

It's fine to rebase to the latest master (in fact I often do it), which would require forced push.

Rebasing is necessary in this PR resolve the CI issue.

curbengh · 2019-10-12T06:29:03Z

test/scripts/hexo/post.js

@@ -717,4 +717,27 @@ describe('Post', () => {
    });
  });

+  // test for Issue [#2318](https://github.com/hexojs/hexo/issues/2318)


I think // test for Issue #2318 is sufficient without the full link.

curbengh · 2019-10-12T09:46:15Z

By the way #3318 is not fixed by this patch.
It seems like #2969.

I created a fix hexojs/hexo-util#110 for those issues. Tested with this PR.

But the fix comes with some caveat; oh well, I would suggest user to use {% blockquote %} then.

test/scripts/hexo/post.js

curbengh · 2019-10-13T00:57:08Z

@seaoak

I've rebased this PR, so all test pass now. My apology if this come off as a bit rude, I just want to include this PR into v4.

seaoak · 2019-10-13T02:42:42Z

@curbengh Thank you for your review and rebase! 😄
I agree all your comments and changes.
And I'm glad this patch will be included into v4.

hexojs#2321) * test(backtick): update comment * Allow backtick code block in "blockquote" tag plugin (hexojs#2318) When backtick code block(s) exist as contents of a "blockquote" tag plugin, each code block is translated to a string "undefined" in HTML (Issue hexojs#2318). In analyzing markdown source text, while the replacement of these elements with placeholders are nesting, recoveries from placeholders are executed only once. So I modify to repeat the recovery process until all placeholders are recovered. * require assert

NoahDragon mentioned this pull request May 4, 2017

Can't use backtick code block in "blockquote" tag plugin #2318

Closed

seaoak mentioned this pull request May 24, 2017

Allow backtick code block in "blockquote" tag plugin (#2318) #2319

Closed

stale bot added the wontfix This will not be worked on label Sep 27, 2017

hexojs deleted a comment from stale bot Sep 27, 2017

NoahDragon added enhancement New feature or request and removed wontfix This will not be worked on labels Sep 27, 2017

ivan-nginx previously approved these changes Jun 13, 2018

View reviewed changes

curbengh mentioned this pull request Oct 30, 2018

code in blockquote display error #3318

Closed

curbengh mentioned this pull request Nov 1, 2018

'post_path' tag plugin doesn't work in markdown []() #3321

Closed

seaoak and others added 3 commits October 10, 2019 05:36

test(backtick): update comment

8240f14

require assert

11c032b

seaoak dismissed ivan-nginx’s stale review via 1c58748 October 11, 2019 20:17

seaoak force-pushed the feature/allow-backtick-code-block-in-blockquote-tag-plugin branch from bb9aaa5 to 1c58748 Compare October 11, 2019 20:17

curbengh reviewed Oct 12, 2019

View reviewed changes

curbengh added this to In progress in v4.0.0 via automation Oct 12, 2019

curbengh added this to the v4.0.0 milestone Oct 12, 2019

curbengh moved this from In progress to To do in v4.0.0 Oct 12, 2019

curbengh reviewed Oct 12, 2019

View reviewed changes

test/scripts/hexo/post.js Outdated Show resolved Hide resolved

curbengh force-pushed the feature/allow-backtick-code-block-in-blockquote-tag-plugin branch from 1c58748 to 8240f14 Compare October 13, 2019 00:50

v4.0.0 automation moved this from To do to In progress Oct 13, 2019

curbengh approved these changes Oct 13, 2019

View reviewed changes

curbengh requested a review from a team October 13, 2019 00:57

SukkaW approved these changes Oct 13, 2019

View reviewed changes

SukkaW merged commit 79bdc95 into hexojs:master Oct 13, 2019

v4.0.0 automation moved this from In progress to Done Oct 13, 2019

snyk-bot mentioned this pull request Mar 16, 2020

[Snyk] Upgrade hexo from 4.0.0 to 4.2.0 MichaelKohler/michaelkohler.info#14

Merged

SukkaW mentioned this pull request Sep 20, 2021

refactor/perf(post): use state machine to escape swig tag #4780

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow backtick code block in "blockquote" tag plugin (#2318) #2321

Allow backtick code block in "blockquote" tag plugin (#2318) #2321

seaoak commented Dec 19, 2016

coveralls commented Dec 19, 2016 •

edited

NoahDragon commented Dec 19, 2016

ivan-nginx left a comment •

edited

curbengh commented Oct 30, 2018 •

edited

yoshinorin commented Nov 10, 2018

tcrowe commented Nov 10, 2018

curbengh commented Nov 12, 2018 •

edited

seaoak commented Nov 12, 2018

yoshinorin commented Nov 13, 2018

JLHwung commented Dec 1, 2018

stevenjoezhang commented Sep 30, 2019

seaoak commented Oct 10, 2019

seaoak commented Oct 11, 2019

seaoak commented Oct 12, 2019

SukkaW commented Oct 12, 2019

curbengh commented Oct 12, 2019 •

edited

curbengh Oct 12, 2019

curbengh commented Oct 12, 2019 •

edited

curbengh commented Oct 13, 2019

seaoak commented Oct 13, 2019

Allow backtick code block in "blockquote" tag plugin (#2318) #2321

Allow backtick code block in "blockquote" tag plugin (#2318) #2321

Conversation

seaoak commented Dec 19, 2016

coveralls commented Dec 19, 2016 • edited

NoahDragon commented Dec 19, 2016

ivan-nginx left a comment • edited

Choose a reason for hiding this comment

curbengh commented Oct 30, 2018 • edited

yoshinorin commented Nov 10, 2018

tcrowe commented Nov 10, 2018

curbengh commented Nov 12, 2018 • edited

seaoak commented Nov 12, 2018

yoshinorin commented Nov 13, 2018

JLHwung commented Dec 1, 2018

stevenjoezhang commented Sep 30, 2019

seaoak commented Oct 10, 2019

seaoak commented Oct 11, 2019

seaoak commented Oct 12, 2019

SukkaW commented Oct 12, 2019

curbengh commented Oct 12, 2019 • edited

curbengh Oct 12, 2019

Choose a reason for hiding this comment

curbengh commented Oct 12, 2019 • edited

curbengh commented Oct 13, 2019

seaoak commented Oct 13, 2019

coveralls commented Dec 19, 2016 •

edited

ivan-nginx left a comment •

edited

curbengh commented Oct 30, 2018 •

edited

curbengh commented Nov 12, 2018 •

edited

curbengh commented Oct 12, 2019 •

edited

curbengh commented Oct 12, 2019 •

edited